Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ParallelEnv always creates and EnvCreator for compatibility with collectors #445

Closed
wants to merge 1 commit into from
Closed

[Feature] ParallelEnv always creates and EnvCreator for compatibility with collectors #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions torchrl/envs/batched_envs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
VERBOSE,
)
from torchrl.data.tensor_specs import CompositeSpec
from torchrl.data.utils import CloudpickleWrapper, contains_lazy_spec, DEVICE_TYPING
from torchrl.data.utils import contains_lazy_spec, DEVICE_TYPING
from torchrl.envs.common import _EnvPostInit, EnvBase
from torchrl.envs.env_creator import get_env_metadata

Expand Down Expand Up @@ -308,6 +308,13 @@ def __init__(
self.policy_proof = policy_proof
self.num_workers = num_workers
self.create_env_fn = create_env_fn

from torchrl.envs.env_creator import EnvCreator

for i, env_fun in enumerate(self.create_env_fn):
if not isinstance(env_fun, EnvCreator) and not isinstance(env_fun, EnvBase):
self.create_env_fn[i] = EnvCreator(env_fun)

self.create_env_kwargs = create_env_kwargs
self.pin_memory = pin_memory
if pin_memory:
Expand Down Expand Up @@ -1050,7 +1057,6 @@ class ParallelEnv(BatchedEnvBase, metaclass=_PEnvMeta):
"""

def _start_workers(self) -> None:
from torchrl.envs.env_creator import EnvCreator

if self.num_threads is None:
self.num_threads = max(
Expand Down Expand Up @@ -1089,8 +1095,6 @@ def look_for_cuda(tensor, has_cuda=has_cuda):
# No certainty which module multiprocessing_context is
parent_pipe, child_pipe = ctx.Pipe()
env_fun = self.create_env_fn[idx]
if not isinstance(env_fun, EnvCreator):
env_fun = CloudpickleWrapper(env_fun)
kwargs[idx].update(
{
"parent_pipe": parent_pipe,
Expand Down
Loading