-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rockset migration - update queue times - set aws permissions in workflow #5411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@@ -14,6 +14,12 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v3 | |||
- run: yarn install --frozen-lockfile | |||
- name: configure aws credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, it's really easy to miss the id-token: write
part :)
steps: | ||
- uses: actions/checkout@v3 | ||
- run: yarn install --frozen-lockfile | ||
- name: configure aws credentials | ||
id: aws_creds | ||
uses: aws-actions/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 1.7.0 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, we couldn't use v4 because of Node 20, but v3 works fine #4869 (instead of 1.7.0)
Role defined in https://github.com/pytorch-labs/pytorch-gha-infra/pull/441
Related