Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rockset migration - update queue times - set aws permissions in workflow #5411

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Rockset migration - update queue times - set aws permissions in workflow #5411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f988617
tc
clee2000 Jul 9, 2024
01454e0
tc
clee2000 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/update-queue-times.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,17 @@ defaults:
jobs:
update-queue-rockset:
runs-on: ubuntu-20.04
permissions:
id-token: write
steps:
- uses: actions/checkout@v3
- run: yarn install --frozen-lockfile
- name: configure aws credentials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, it's really easy to miss the id-token: write part :)

id: aws_creds
uses: aws-actions/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 1.7.0 version?

Copy link
Contributor

@huydhn huydhn Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we couldn't use v4 because of Node 20, but v3 works fine #4869 (instead of 1.7.0)

with:
role-to-assume: arn:aws:iam::308535385114:role/gha_workflow_update_queue_times
aws-region: us-east-1
- run: yarn node scripts/updateQueueTimes.mjs
env:
ROCKSET_API_KEY: ${{ secrets.ROCKSET_API_KEY }}
Loading