return work from manager allreduce #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: use http transport instead of pg transport -- pg transport fails to resolve address when running locally
This was referenced Jul 26, 2025
Merged
facebook-github-bot
added
the
CLA Signed
tushar00jain
changed the title
tushar00jain
force-pushed
the
pr247
branch
3 times, most recently
from
48daf18 to
e6715b0
Compare
tushar00jain
force-pushed
the
pr247
branch
4 times, most recently
from
843854d to
1bfb3d8
Compare
d4l3k
requested changes
Jul 29, 2025
tushar00jain
force-pushed
the
pr247
branch
6 times, most recently
from
e83bf1e to
0973ddc
Compare
d4l3k
approved these changes
Jul 30, 2025
| fut = fut.then(callback) | ||
| return fut | ||
| fut.add_done_callback(callback) | ||
| return work |
There was a problem hiding this comment.
should this be using _WorkWrapper ?
There was a problem hiding this comment.
that's returned by manager. the manager calls this method inside allreduce
tushar00jain
force-pushed
the
pr247
branch
10 times, most recently
from
411ae90 to
fd371a7
Compare
Summary: - call future.wait in callbacks to make sure the continuation executes after the future has completed - set the stream correctly to execute callback scheduled by bucketized allreduce
Summary: returns the work object so we can be more flexible with the usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
returns the work object so we can be more flexible with the usage
Stack created with Sapling. Best reviewed with ReviewStack.