fix managed pg allreduce #249
Open
+595
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2025
facebook-github-bot
added
the
CLA Signed
tushar00jain
force-pushed
the
pr249
branch
14 times, most recently
from
4e84808 to
2ea4d49
Compare
tushar00jain
force-pushed
the
pr249
branch
2 times, most recently
from
222021b to
39bbf8f
Compare
d4l3k
requested changes
Jul 30, 2025
tushar00jain
force-pushed
the
pr249
branch
5 times, most recently
from
1afe947 to
78e1bea
Compare
tushar00jain
force-pushed
the
pr249
branch
18 times, most recently
from
a983b4d to
f4a81c7
Compare
tushar00jain
force-pushed
the
pr249
branch
3 times, most recently
from
b9f938d to
4033168
Compare
Closed
Summary: - improve abstraction and api contract offered by managed work - users can change future return types, ensures users use correct cuda streams - added a managed future that is lazily attaches callbacks - based on when users call wait on the work or the future
Summary: managed pg allreduce should just call manager's allreduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
managed pg allreduce should just call manager's allreduce
Stack created with Sapling. Best reviewed with ReviewStack.