Adding support for MOMENTUM_DIFF and ROWWISE_ADAGRAD optimizer states #3144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ### Overview This diff adds support for tracking optimizer states in the Model Delta Tracker system. It introduces a new tracking mode called `MOMENTUM_LAST` that enables tracking of momentum values from optimizers to support approximate top-k delta-row selection. ### Key Changes #### 1. Optimizer State Tracking Support * To support tracking of optimizer states I have added `optim_state_tracker_fn` attribute to `GroupedEmbeddingsLookup` and `GroupedPooledEmbeddingsLookup` classes responsible for traversing over the BatchedFused modules. * Implemented `register_optim_state_tracker_fn()` method in both classes to register the trackable callable * Tracking calls are invoked after each lookup operation. #### 2. Model Delta Tracker Changes * Added `record_momentum()` method to track momentum values from optimizer states and its support in record_lookup function. * Added validation and optim tracker function logic to support the new `MOMENTUM_LAST` mode #### 3. New Tracking Mode * Added `TrackingMode.MOMENTUM_LAST` to [`**types.py**`](command:code-compose.open?%5B%22%2Ffbcode%2Ftorchrec%2Fdistributed%2Fmodel_tracker%2Ftypes.py%22%2Cnull%5D "/fbcode/torchrec/distributed/model_tracker/types.py") * Maps to `EmbdUpdateMode.LAST` to capture the most recent momentum values Differential Revision: D76868111
Summary: This diff extends the Model Delta Tracker to support two new tracking modes: `MOMENTUM_DIFF` and `ROWWISE_ADAGRAD`, which enable tracking of rowwise optimizer states for more sophisticated gradient analysis. Differential Revision: D76918891
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76918891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff extends the Model Delta Tracker to support two new tracking modes:
MOMENTUM_DIFFandROWWISE_ADAGRAD, which enable tracking of rowwise optimizer states for more sophisticated gradient analysis.Differential Revision: D76918891