MAINT: adds plugin install tab for apple silicon arch #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying library with
|
| Latest commit: |
6db3b12
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00b9829b.library-b91.pages.dev |
| Branch Preview URL: | https://apple-silicon-install-tab.library-b91.pages.dev |
ebolyen
reviewed
Jul 10, 2025
ebolyen
reviewed
Jul 10, 2025
| u('tabItem', key({title: '[Fresh Install (Apple Silicon)]'}), [ | ||
| u('code', key({lang: 'bash', class: '!my-3'}), create_silicon), | ||
| ]), | ||
| u('tabItem', key({title: '[Fresh Install (all other architectures)]'}), [ |
There was a problem hiding this comment.
The titles end up being pretty long, I wonder if we can just have an exception for (Apple Silicon)?
There was a problem hiding this comment.
yeah, i know... i do worry about it being confusing if we only have one arch specified. let me think about other name options to see if there's still a way to convey this that's less verbose
There was a problem hiding this comment.
How do you feel about this @ebolyen?
Co-authored-by: Evan Bolyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19