Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable automatic dashboard deployment #156

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Disable automatic dashboard deployment #156

merged 1 commit into from
Mar 29, 2024

Conversation

vmercierfr
Copy link
Collaborator

Objective

Disable automatic dashboard deployment

Why

Dashboards deployment should be opt-in because deployment could be blocked if Grafana CRD does not exist.

How

  • Set enabled: true

Release plan

  • Merge this PR
  • Apply with CI

@vmercierfr vmercierfr added the bug Something isn't working label Mar 29, 2024
@vmercierfr vmercierfr requested review from dcupif and qfritz March 29, 2024 15:35
@vmercierfr
Copy link
Collaborator Author

#sre

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch 87% ✔
github.com/qonto/prometheus-rds-exporter/internal/app/ec2 87% ✔
github.com/qonto/prometheus-rds-exporter/internal/app/exporter 80% ✔
github.com/qonto/prometheus-rds-exporter/internal/app/rds 75% ➖
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas 51% ❌
github.com/qonto/prometheus-rds-exporter/internal/app/trace 100% ✔
github.com/qonto/prometheus-rds-exporter/internal/app/unit 100% ✔
Summary 80% (1030 / 1290) ➖

Minimum allowed line rate is 60%

@vmercierfr vmercierfr merged commit ed80d43 into main Mar 29, 2024
11 checks passed
@vmercierfr vmercierfr deleted the disable-dashboards branch March 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qfritz qfritz qfritz approved these changes

@dcupif dcupif Awaiting requested review from dcupif

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmercierfr @qfritz