Skip to content

Switch to unquoted type annotations part 7 #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented May 15, 2025

No change in the effective code. A batch of 100 files (~700 to go).
Added future import of annotations to detect typing-only imports.

Passes ruff check --target-version=py311 --select=UP037,TC001

Partially implements #1999

No change in the effective code.  A batch of 100 files (~700 to go).
Added future import of annotations to detect typing-only imports.

Passes  ruff check --target-version=py310 --select=UP037,TC001

Partially implements quantumlib#1999
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners May 15, 2025 20:54
@pavoljuhas pavoljuhas requested a review from viathor May 15, 2025 20:54
@github-actions github-actions bot added the size: M 50< lines changed <250 label May 15, 2025
@pavoljuhas pavoljuhas requested a review from mhucka May 15, 2025 20:55
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (01e3e9c) to head (ee381d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7343      +/-   ##
==========================================
- Coverage   98.67%   98.67%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       96904    96997      +93     
==========================================
+ Hits        95621    95712      +91     
- Misses       1283     1285       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue May 16, 2025
Merged via the queue into quantumlib:main with commit b4bcdfb May 16, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the use-future-annotations-7 branch May 16, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants