draft: add extended-span-chat-model-listener #1260
Draft
+62
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! I will have a closer look in a few days as I am traveling |
geoand
reviewed
Feb 3, 2025
| /** | ||
| * extended ChatModelListener adding possibility to add custom attributes to span | ||
| */ | ||
| public interface ExtendedSpanChatModelListener { |
There was a problem hiding this comment.
I would probably call this ChatModelSpanEnhancer
There was a problem hiding this comment.
if you like it i can rename and make it merge-ready
There was a problem hiding this comment.
I want to take a closer look in a few days.
But the PR will also need to make sure that the beans are picked up (if they exist) and work regardless of whether such beans are present
There was a problem hiding this comment.
I thought about this a little more and I like the approach a lot.
So let's make sure it works under all circumstances (ideally with some tests) and also document it.
enabling adding more/custom attributes to span, namely before span is closed quarkiverse#1256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabling adding more/custom attributes to span, namely before span is closed
for
onRequestthis would already be possible just using anotherChatModelListener. not so unfortunately foronResponseas span is ended inSpanChatModelListener.onResponse()and so additional attributes land on parent-span overwriting each other with every new request.this change is just missing some
ProcessorMagic producing a default-ExtendedSpanChatModelListenerand some docs may-be.