-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: add extended-span-chat-model-listener #1260
Draft
flyinfish
wants to merge
1
commit into
quarkiverse:main
Choose a base branch
from
flyinfish:1256
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−4
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
53 changes: 53 additions & 0 deletions
53
...main/java/io/quarkiverse/langchain4j/runtime/listeners/ExtendedSpanChatModelListener.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
package io.quarkiverse.langchain4j.runtime.listeners; | ||
|
||
import dev.langchain4j.model.chat.listener.ChatModelErrorContext; | ||
import dev.langchain4j.model.chat.listener.ChatModelRequest; | ||
import dev.langchain4j.model.chat.listener.ChatModelRequestContext; | ||
import dev.langchain4j.model.chat.listener.ChatModelResponse; | ||
import dev.langchain4j.model.chat.listener.ChatModelResponseContext; | ||
import io.opentelemetry.api.trace.Span; | ||
|
||
/** | ||
* extended ChatModelListener adding possibility to add custom attributes to span | ||
*/ | ||
public interface ExtendedSpanChatModelListener { | ||
/** | ||
* Allowing extendes Span-Attributes {@link SpanChatModelListener} | ||
* | ||
* @param requestContext The request context. It contains the {@link ChatModelRequest} and attributes. | ||
* The attributes can be used to pass data between methods of this listener | ||
* or between multiple listeners. | ||
* @param currentSpan Span opened by {@link SpanChatModelListener}. | ||
*/ | ||
default void onRequest(ChatModelRequestContext requestContext, Span currentSpan) { | ||
|
||
} | ||
|
||
/** | ||
* Allowing extendes Span-Attributes {@link SpanChatModelListener} | ||
* | ||
* @param responseContext The response context. | ||
* It contains {@link ChatModelResponse}, corresponding {@link ChatModelRequest} and attributes. | ||
* The attributes can be used to pass data between methods of this listener | ||
* or between multiple listeners. | ||
* @param currentSpan Span opened by {@link SpanChatModelListener}. | ||
*/ | ||
default void onResponse(ChatModelResponseContext responseContext, Span currentSpan) { | ||
|
||
} | ||
|
||
/** | ||
* Allowing extendes Span-Attributes {@link SpanChatModelListener} | ||
* | ||
* @param errorContext The error context. | ||
* It contains the error, corresponding {@link ChatModelRequest}, | ||
* partial {@link ChatModelResponse} (if available) and attributes. | ||
* The attributes can be used to pass data between methods of this listener | ||
* or between multiple listeners. | ||
* @param currentSpan Span opened by {@link SpanChatModelListener}. | ||
*/ | ||
default void onError(ChatModelErrorContext errorContext, Span currentSpan) { | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably call this
ChatModelSpanEnhancer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you like it i can rename and make it merge-ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to take a closer look in a few days.
But the PR will also need to make sure that the beans are picked up (if they exist) and work regardless of whether such beans are present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this a little more and I like the approach a lot.
So let's make sure it works under all circumstances (ideally with some tests) and also document it.