Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: add extended-span-chat-model-listener #1260

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package io.quarkiverse.langchain4j.runtime.listeners;

import dev.langchain4j.model.chat.listener.ChatModelErrorContext;
import dev.langchain4j.model.chat.listener.ChatModelRequest;
import dev.langchain4j.model.chat.listener.ChatModelRequestContext;
import dev.langchain4j.model.chat.listener.ChatModelResponse;
import dev.langchain4j.model.chat.listener.ChatModelResponseContext;
import io.opentelemetry.api.trace.Span;

/**
* extended ChatModelListener adding possibility to add custom attributes to span
*/
public interface ExtendedSpanChatModelListener {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably call this ChatModelSpanEnhancer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you like it i can rename and make it merge-ready

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to take a closer look in a few days.

But the PR will also need to make sure that the beans are picked up (if they exist) and work regardless of whether such beans are present

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this a little more and I like the approach a lot.
So let's make sure it works under all circumstances (ideally with some tests) and also document it.

/**
* Allowing extendes Span-Attributes {@link SpanChatModelListener}
*
* @param requestContext The request context. It contains the {@link ChatModelRequest} and attributes.
* The attributes can be used to pass data between methods of this listener
* or between multiple listeners.
* @param currentSpan Span opened by {@link SpanChatModelListener}.
*/
default void onRequest(ChatModelRequestContext requestContext, Span currentSpan) {

}

/**
* Allowing extendes Span-Attributes {@link SpanChatModelListener}
*
* @param responseContext The response context.
* It contains {@link ChatModelResponse}, corresponding {@link ChatModelRequest} and attributes.
* The attributes can be used to pass data between methods of this listener
* or between multiple listeners.
* @param currentSpan Span opened by {@link SpanChatModelListener}.
*/
default void onResponse(ChatModelResponseContext responseContext, Span currentSpan) {

}

/**
* Allowing extendes Span-Attributes {@link SpanChatModelListener}
*
* @param errorContext The error context.
* It contains the error, corresponding {@link ChatModelRequest},
* partial {@link ChatModelResponse} (if available) and attributes.
* The attributes can be used to pass data between methods of this listener
* or between multiple listeners.
* @param currentSpan Span opened by {@link SpanChatModelListener}.
*/
default void onError(ChatModelErrorContext errorContext, Span currentSpan) {

}

}
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,13 @@ public class SpanChatModelListener implements ChatModelListener {

private final Tracer tracer;
private final CostEstimatorService costEstimatorService;

private final ExtendedSpanChatModelListener extendedSpanChatModelListener;

@Inject
public SpanChatModelListener(Tracer tracer, CostEstimatorService costEstimatorService) {
this.tracer = tracer;
this.costEstimatorService = costEstimatorService;
public SpanChatModelListener(Tracer tracer, CostEstimatorService costEstimatorService, ExtendedSpanChatModelListener extendedSpanChatModelListener) {
this.tracer = tracer;
this.costEstimatorService = costEstimatorService;
this.extendedSpanChatModelListener = extendedSpanChatModelListener;
}

@Override
Expand All @@ -53,6 +55,7 @@ public void onRequest(ChatModelRequestContext requestContext) {
var attributes = requestContext.attributes();
attributes.put(OTEL_SCOPE_KEY_NAME, scope);
attributes.put(OTEL_SPAN_KEY_NAME, span);
extendedSpanChatModelListener.onRequest(requestContext, span);
}

@Override
Expand All @@ -78,6 +81,7 @@ public void onResponse(ChatModelResponseContext responseContext) {
span.setAttribute("gen_ai.client.estimated_cost", costEstimate.toString());
}
}
extendedSpanChatModelListener.onResponse(responseContext, span);
span.end();
} else {
// should never happen
Expand All @@ -91,6 +95,7 @@ public void onError(ChatModelErrorContext errorContext) {
var attributes = errorContext.attributes();
Span span = (Span) attributes.get(OTEL_SPAN_KEY_NAME);
if (span != null) {
extendedSpanChatModelListener.onError(errorContext, span);
span.recordException(errorContext.error());
} else {
// should never happen
Expand Down
Loading