-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #824 - Introduce a separated OIDC module to hold security dependencies #872
Conversation
…ity dependencies Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
works for me, quarkus starts now with quarkus-hibernate-validator. |
@gastaldi do I have to do anything else to release the new module? |
@ricardozanini you can use conditional dependencies to have your module added automatically when |
No, it should work as usual |
oh nice! I'll do that then :D |
After reviewing the code base to add these conditionals, I'd have to create a new It's unnecessary to add all this complexity to the code base at this moment. OIDC support will work if users can add the new module we introduced today to their dependencies. This new way of generating authentication classes did more harm than good. This rework should have been done in the original PR, but I don't have time to implement it now. If someone from the community is interested, please let me know. |
…ncies (#872) * Fix #824 - Introduce a separated OIDC module to hold security dependencies Signed-off-by: Ricardo Zanini <[email protected]> * Fix parent module Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]>
…ncies (#872) (#874) * Fix #824 - Introduce a separated OIDC module to hold security dependencies * Fix parent module --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Fix #824
In this PR:
runtime
modulequarkus-openapi-generator-oidc
component to hold OIDC use cases; users now MUST add this new dependency to their project in case OIDC is required.integration-tests
module to remove OIDC from every module; just add tosecurity
where it's really required.Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2
to backport the original PR to thequarkus2
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.