-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 3.0.yaml to use newArtifactId:
instead of deprecated newArtifact:
#236
Conversation
- Following on from openrewrite/rewrite#4421
I guess it's good to consume the project you maintain from time to time; apologies for the breaking changes! 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@timtebeek I'm rather concerned by the license change of the entirety of https://github.com/openrewrite/rewrite-migrate-java/ . I can understand the point of view of Moderne regarding the advanced modernization recipes (not saying I like it but that's your choice as long as you respect the contributors IP) but even some basic building blocks like I suppose the move of I think our recipes are built on what should be considered open basic building blocks (we don't really want to modernize the applications, just to upgrade them to a new Quarkus version, people can use OpenRewrite or Moderne by themselves if they are after modernization) and I'm not sure I'm comfortable updating to a new version until this is resolved and we don't end up using recipes under a new not OSI-approved license (well, to be perfectly honest, I'm sure I'm not comfortable doing it). Happy to discuss it on a call if you feel like it. |
Hi @gsmet Appreciate your concern; know that for the purpose of this PR I've intentionally upgraded you to the last release that still used the Apache License for all the components, such that there should not be any hesitation accepting this particular changeset. Perhaps indeed best to schedule a call to go over your concerns and figure out the best path forward; any day between ~11:00 and ~14:00 usually works for me, to feel free to send out an invite and we'll connect there. |
Following on from
And especially relevant now with
ChangePluginGroupIdAndArtifactId does not allow for updating maven plugin versions openrewrite/rewrite#4902
Fixes Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.17.0 to 2.21.1 #226