Merge pull request #46255 from geoand/MongoClients-polish

Apply minor polish to MongoClients
quarkusio · Feb 13, 2025 · 1bdd69f · 1bdd69f
2 parents 6adbc78 + 64f613c
commit 1bdd69f
Showing 1 changed file with 10 additions and 25 deletions.
diff --git a/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/MongoClients.java b/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/MongoClients.java
@@ -146,7 +146,7 @@ public ClusterSettingBuilder(MongoClientConfig config) {
             this.config = config;
         }
 
-        private MongoClientConfig config;
+        private final MongoClientConfig config;
 
         @Override
         public void apply(ClusterSettings.Builder builder) {
@@ -180,8 +180,8 @@ public ConnectionPoolSettingsBuilder(MongoClientConfig config, List<ConnectionPo
             this.connectionPoolListeners = connectionPoolListeners;
         }
 
-        private MongoClientConfig config;
-        private List<ConnectionPoolListener> connectionPoolListeners;
+        private final MongoClientConfig config;
+        private final List<ConnectionPoolListener> connectionPoolListeners;
 
         @Override
         public void apply(ConnectionPoolSettings.Builder builder) {
@@ -211,8 +211,8 @@ public SslSettingsBuilder(MongoClientConfig config, boolean disableSslSupport) {
             this.disableSslSupport = disableSslSupport;
         }
 
-        private MongoClientConfig config;
-        private boolean disableSslSupport;
+        private final MongoClientConfig config;
+        private final boolean disableSslSupport;
 
         @Override
         public void apply(SslSettings.Builder builder) {
@@ -225,7 +225,7 @@ public SocketSettingsBuilder(MongoClientConfig config) {
             this.config = config;
         }
 
-        private MongoClientConfig config;
+        private final MongoClientConfig config;
 
         @Override
         public void apply(SocketSettings.Builder builder) {
@@ -243,7 +243,7 @@ public ServerSettingsBuilder(MongoClientConfig config) {
             this.config = config;
         }
 
-        private MongoClientConfig config;
+        private final MongoClientConfig config;
 
         @Override
         public void apply(ServerSettings.Builder builder) {
@@ -466,8 +466,8 @@ private MongoCredential createMongoCredential(MongoClientConfig config) {
             usernamePassword = new UsernamePassword(null, null);
         }
         // Create the MongoCredential instance.
-        String username = usernamePassword.getUsername();
-        char[] password = usernamePassword.getPassword();
+        String username = usernamePassword.username();
+        char[] password = usernamePassword.password();
         MongoCredential credential;
         if (mechanism == GSSAPI) {
             credential = MongoCredential.createGSSAPICredential(username);
@@ -540,21 +540,6 @@ public void stop() {
         }
     }
 
-    private static class UsernamePassword {
-        private final String username;
-        private final char[] password;
-
-        public UsernamePassword(String username, char[] password) {
-            this.username = username;
-            this.password = password;
-        }
-
-        public String getUsername() {
-            return username;
-        }
-
-        public char[] getPassword() {
-            return password;
-        }
+    private record UsernamePassword(String username, char[] password) {
     }
 }