Move narayana-lra extension to the new separated LRA project #44513
+19
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
Status for workflow
|
|
🎊 PR Preview 0e67055 has been successfully built and deployed to https://quarkus-pr-main-44513-preview.surge.sh/version/main/guides/
|
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 21 #
- Failing: integration-tests/test-extension/extension/deployment
! Skipped: integration-tests/test-extension/tests 📦 integration-tests/test-extension/extension/deployment
✖ io.quarkus.extest.OverrideBuildTimeConfigTest. - History - More details - Source on GitHub
java.lang.RuntimeException: java.lang.RuntimeException: The produced jar could not be launched. Consult the above output for the exact cause.
at io.quarkus.test.QuarkusProdModeTest.beforeAll(QuarkusProdModeTest.java:499)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: The produced jar could not be launched. Consult the above output for the exact cause.
at io.quarkus.test.QuarkusProdModeTest.ensureApplicationStartupOrFailure(QuarkusProdModeTest.java:691)
at io.quarkus.test.QuarkusProdModeTest.start(QuarkusProdModeTest.java:617)
at io.quarkus.test.QuarkusProdModeTest.beforeAll(QuarkusProdModeTest.java:486)
... 1 more
Flaky tests - Develocity
⚙️ JVM Tests - JDK 21
📦 extensions/smallrye-reactive-messaging-kafka/deployment
✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - History
io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)-java.lang.RuntimeException
java.lang.RuntimeException:
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
|
@radcortez I think we have a problem with the new config stuff. We have another failure here with: |
|
I was looking into it, but I really can't explain the cause yet. To make things worse, it is an intermittent error :( |
gsmet
requested changes
Nov 15, 2024
| @@ -97,6 +97,7 @@ | |||
| <!-- See root POM for hibernate-orm.version, hibernate-reactive.version, hibernate-validator.version, | |||
| hibernate-search.version, antlr.version, bytebuddy.version, hibernate-commons-annotations.version --> | |||
| <narayana.version>7.1.0.Final</narayana.version> | |||
| <narayana.version.lra>0.0.9.Final</narayana.version.lra> | |||
There was a problem hiding this comment.
Let's use narayana-lra.version instead please.
Comment on lines
4773
to
4776
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>narayana-lra</artifactId> | ||
| </exclusion> |
There was a problem hiding this comment.
Not related to your patch but while we're at it: I think this exclusion can go away. Probably some remnants from when we had the Jakarta artifacts.
Comment on lines
4796
to
4799
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>lra-service-base</artifactId> | ||
| </exclusion> |
Comment on lines
4816
to
4819
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>lra-proxy-api</artifactId> | ||
| </exclusion> |
Comment on lines
4827
to
4830
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>lra-client</artifactId> | ||
| </exclusion> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narayana LRA moved to a separate repository with a separate lifecycle - https://github.com/jbosstm/lra.