Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move narayana-lra extension to the new separated LRA project #44513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −18
Open

Move narayana-lra extension to the new separated LRA project #44513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
<!-- See root POM for hibernate-orm.version, hibernate-reactive.version, hibernate-validator.version,
hibernate-search.version, antlr.version, bytebuddy.version, hibernate-commons-annotations.version -->
<narayana.version>7.1.0.Final</narayana.version>
<narayana.version.lra>0.0.9.Final</narayana.version.lra>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use narayana-lra.version instead please.

<agroal.version>2.5</agroal.version>
<jboss-transaction-spi.version>8.0.0.Final</jboss-transaction-spi.version>
<elasticsearch-opensource-components.version>8.16.0</elasticsearch-opensource-components.version>
Expand Down Expand Up @@ -4765,12 +4766,12 @@
<version>${microprofile-lra.version}</version>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>narayana-lra</artifactId>
<version>${narayana.version}</version>
<version>${narayana.version.lra}</version>
<exclusions>
<exclusion>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>narayana-lra</artifactId>
</exclusion>
Comment on lines 4773 to 4776
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your patch but while we're at it: I think this exclusion can go away. Probably some remnants from when we had the Jakarta artifacts.

<exclusion>
Expand All @@ -4788,12 +4789,12 @@
</exclusions>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-service-base</artifactId>
<version>${narayana.version}</version>
<version>${narayana.version.lra}</version>
<exclusions>
<exclusion>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-service-base</artifactId>
</exclusion>
Comment on lines 4796 to 4799
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

<exclusion>
Expand All @@ -4808,23 +4809,23 @@
</exclusions>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-proxy-api</artifactId>
<version>${narayana.version}</version>
<version>${narayana.version.lra}</version>
<exclusions>
<exclusion>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-proxy-api</artifactId>
</exclusion>
Comment on lines 4816 to 4819
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

</exclusions>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-client</artifactId>
<version>${narayana.version}</version>
<version>${narayana.version.lra}</version>
<exclusions>
<exclusion>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-client</artifactId>
</exclusion>
Comment on lines 4827 to 4830
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

<exclusion>
Expand Down
12 changes: 6 additions & 6 deletions extensions/narayana-lra/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
<artifactId>quarkus-arc</artifactId>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>narayana-lra</artifactId>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-service-base</artifactId>
<exclusions>
<exclusion>
Expand All @@ -34,7 +34,7 @@
</exclusions>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-proxy-api</artifactId>
<exclusions>
<exclusion>
Expand All @@ -44,7 +44,7 @@
</exclusions>
</dependency>
<dependency>
<groupId>org.jboss.narayana.rts</groupId>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-client</artifactId>
</dependency>
<dependency>
Expand All @@ -69,11 +69,11 @@
<configuration>
<removedResources>
<artifact>
<key>org.jboss.narayana.rts:narayana-lra</key>
<key>org.jboss.narayana.lra:narayana-lra</key>
<resources>META-INF/services/jakarta.ws.rs.client.ClientBuilder</resources>
</artifact>
<artifact>
<key>org.jboss.narayana.rts:lra-client</key>
<key>org.jboss.narayana.lra:lra-client</key>
<resources>META-INF/services/jakarta.ws.rs.client.ClientBuilder</resources>
</artifact>
</removedResources>
Expand Down
Loading