-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index quarkiverse guides #260
base: main
Are you sure you want to change the base?
Index quarkiverse guides #260
Conversation
Assuming HTML files are generated, you could adjust the Quarkiverse build to generate a YAML file, too. @gastaldi any pointers to the Quarkiverse website build?
Most likely we'll want to integrate search.quarkus.io there, yes, but that can be a second step. |
src/main/java/io/quarkus/search/app/indexing/IndexingService.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
@Test | ||
@Disabled("Since quarkiverse guides are now fetched directly from their site there is no translation for them available anymore") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a problem, no?
Though I'm not sure why there was a translation in the first place...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mainly about the Japanese version. There are those few Quarkiverse guides that are mentioned on the quarkus.io/guides, and their titles have been translated. But now, when we index this from the Quarkiverse side, there are no translation files. We probably could try to use the translation files for the main version and hope to find some matches, but I wasn't sure it was worth it. In particular, because the titles are concatenated here + the summary isn't the one from the yaml, so there probably won't be a lot of matches.
With these two: quarkiverse/quarkiverse-docs#159 It works like this: the way I've been testing it locally
|
Well that's quite a bit of CXF :] LGTM, though I'd personally prefer the Quarkiverse build to generate some YAML for you to parse. HTML scraping isn't exactly the most reliable way of going about that sort of things :) So:
|
The website is built here: https://github.com/quarkiverse/quarkiverse-docs/blob/main/.github/workflows/publish.yml#L36. Adding a new step there or changing the |
I don't think the package.json change is related, but okay, so the changes need to go there somehow. @marko-bekhta you'll probably want to update CORS rules as well, to allow |
I thought about this a bit.. If we'd go with adding additional steps to the Quarkiverse build, for it to make sense we'd need:
antora.yml files in extension repositories (e.g. https://github.com/quarkiverse/quarkus-cxf/blob/main/docs/antora.yml) do not help us much as they don't have the docs-tree structure, and working with https://github.com/quarkiverse/quarkus-cxf/tree/main/docs/modules/ROOT/pages would mean that we'd need to parse adoc files ... If that's so I'd rather deal with parsing HTMLs in Java 😃 then doing all of the above 🙈. The HTML layout should be stable and can only change if the Quarkiverse theme layout (https://github.com/quarkiverse/antora-ui-quarkiverse) is modified |
That... seems like a blocker, considering the amount of Quarkiverse extensions.
Parsing |
I suspect we already parse this file, by the way, judging from the comments near the end of this one: https://raw.githubusercontent.com/quarkiverse/quarkus-cxf/main/docs/modules/ROOT/nav.adoc ( |
fixes #143
I've played with this a bit, and from what it seems, the simplest way is to just parse the https://docs.quarkiverse.io/index/explore/index.html ...
I haven't found any repository where the HTMLs are pre-built so we could read from them rather than over the HTTP...
since there can be multiple pages under one "extension-guide" I've prefixed all of them with the name of the extension itself.
This will only include the Quarkiverse guides in the search on https://quarkus.io/guides/
Do we want to do anything on the https://docs.quarkiverse.io/index/explore/index.html as well ?