Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow for making releases #121

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add workflow for making releases #121

merged 1 commit into from
Nov 23, 2023

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Nov 22, 2023

No description provided.

@saghul saghul marked this pull request as draft November 22, 2023 22:03
@saghul saghul force-pushed the ci-release branch 4 times, most recently from 8ac5592 to d140076 Compare November 22, 2023 22:43
@saghul saghul mentioned this pull request Nov 22, 2023
Closed
@saghul saghul force-pushed the ci-release branch 2 times, most recently from e4a69f4 to 06f67c3 Compare November 23, 2023 10:27
@saghul saghul requested a review from bnoordhuis November 23, 2023 10:37
@saghul saghul marked this pull request as ready for review November 23, 2023 10:37
@saghul
Copy link
Contributor Author

saghul commented Nov 23, 2023

This is now ready. Sample run: https://github.com/saghul/quickjs/releases/tag/v0.1.2

The workflow is:

  • Create a new release on GH and use a tag name of the form vX.Y.Z
  • The release must NOT be a draft release
  • The release GH action will run and upload the artifacts to the existing release
  • Profit!

I don't see a very good place to put the LATEST.json file and since jsvu also works with the GH API I'll go with that first.

@saghul saghul merged commit af456e6 into master Nov 23, 2023
19 checks passed
@saghul saghul deleted the ci-release branch November 23, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saghul