feat(ActionMenu<Scan>): ds-437 add download report button #513
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm run start:using-server will serve the development UI properly wired to a running instance of quipucords server. Default configuration points to quipucords-installer defaults, and can be customized with QUIPUCORDS_SERVER_* variables.
The button shall only be enabled when the scan is completed.
|
Thanks for adding this @bruno-fs. Let try to get this one in for the v2 release, since it addresses a blocker issue. |
|
After sleeping on it, I believe we could test this workflow directly in the camayoc, given that we were missing the step to complete the standard workflow for scanning. Thoughts, @mirekdlugosz & @ruda ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button shall only be enabled when the scan is completed.
What's included
Includes a dropdown button on scan row kebab for downloading reports.
Notes
report_id(due to a bug/edge-case on the backend?). a client-side error will be thrownExample
Kebab for scans in progress
...and for completed ones
On download completion, an alert should be displayed. Same shall happen on errors, but that's harder to test without
monkey-patching the server
...
Updates issue/story
DISCOVERY-347