Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ShieldBuilder to validate FactorSourceKind for ROLA factors #314

Merged
merged 69 commits into from
Dec 20, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Dec 20, 2024

Upgrade ShieldBuilder to validate FactorSourceKind for ROLA factor.

Also expose functions to query ShieldBuilder for which FactorSourceKinds are valid for ROLA.

@@ -252,6 +252,29 @@ impl SecurityShieldBuilder {

#[uniffi::export]
impl SecurityShieldBuilder {
/// "Statically" queries which FactorSourceKinds are disallowed for authentication signing.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"statically" put in quoutes since UniFFI does not allow static methods to be exported.

Documented here so that one understands that this does not mutate any state.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.3%. Comparing base (87a2400) to head (878bd15).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mfa/security_structures/security_shield_builder.rs 90.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #314     +/-   ##
=======================================
- Coverage   93.3%   93.3%   -0.1%     
=======================================
  Files       1111    1111             
  Lines      24043   24064     +21     
  Branches      79      79             
=======================================
+ Hits       22445   22464     +19     
- Misses      1583    1585      +2     
  Partials      15      15             
Flag Coverage Δ
kotlin 97.1% <ø> (ø)
rust 92.8% <90.9%> (-0.1%) ⬇️
swift 94.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gon/src/profile/v100/factors/factor_source_kind.rs 100.0% <100.0%> (ø)
...mfa/security_structures/security_shield_builder.rs 93.7% <90.0%> (-0.4%) ⬇️

Copy link
Contributor

@danvleju-rdx danvleju-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just bump version :)

@CyonAlexRDX CyonAlexRDX merged commit 191f729 into main Dec 20, 2024
13 checks passed
@CyonAlexRDX CyonAlexRDX deleted the ac/shield_upgrade_validate_kind_for_rola branch December 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants