-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ShieldBuilder
to validate FactorSourceKind
for ROLA factors
#314
Conversation
…to ac/mix_persona_and_accounts_in_factor_instances_provider
…allowed FactorSourceKind - add query methods which can query which kinds are supported/if a kind is supported
…r' into ac/shield_upgrade_validate_kind_for_rola_and_more_lenient_add_factors
@@ -252,6 +252,29 @@ impl SecurityShieldBuilder { | |||
|
|||
#[uniffi::export] | |||
impl SecurityShieldBuilder { | |||
/// "Statically" queries which FactorSourceKinds are disallowed for authentication signing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"statically" put in quoutes since UniFFI does not allow static methods to be exported.
Documented here so that one understands that this does not mutate any state.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
=======================================
- Coverage 93.3% 93.3% -0.1%
=======================================
Files 1111 1111
Lines 24043 24064 +21
Branches 79 79
=======================================
+ Hits 22445 22464 +19
- Misses 1583 1585 +2
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just bump version :)
Upgrade ShieldBuilder to validate
FactorSourceKind
for ROLA factor.Also expose functions to query ShieldBuilder for which FactorSourceKinds are valid for ROLA.