Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ShieldBuilder to validate FactorSourceKind for ROLA factors #314

Merged
merged 69 commits into from
Dec 20, 2024

bump

878bd15
Select commit
Loading
Failed to load commit list.
Merged

Upgrade ShieldBuilder to validate FactorSourceKind for ROLA factors #314

bump
878bd15
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 0s

93.3% (-0.1%) compared to 87a2400, passed because coverage increased by 0% when compared to adjusted base (93.3%)

View this Pull Request on Codecov

93.3% (-0.1%) compared to 87a2400, passed because coverage increased by 0% when compared to adjusted base (93.3%)

Details

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.3%. Comparing base (87a2400) to head (878bd15).

Files with missing lines Patch % Lines
...mfa/security_structures/security_shield_builder.rs 90.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #314     +/-   ##
=======================================
- Coverage   93.3%   93.3%   -0.1%     
=======================================
  Files       1111    1111             
  Lines      24043   24064     +21     
  Branches      79      79             
=======================================
+ Hits       22445   22464     +19     
- Misses      1583    1585      +2     
  Partials      15      15             
Files with missing lines Coverage Δ
...gon/src/profile/v100/factors/factor_source_kind.rs 100.0% <100.0%> (ø)
...mfa/security_structures/security_shield_builder.rs 93.7% <90.0%> (-0.4%) ⬇️