Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quote.py #1571

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Update quote.py #1571

wants to merge 4 commits into from

Conversation

AKwoKWH
Copy link

@AKwoKWH AKwoKWH commented Jun 24, 2023

To add topHoldings and price for ETF weighting
#1554

@ValueRaider
Copy link
Collaborator

The reason there are other changes is you created your branch from main, but it should be from dev. Branch from dev to merge into dev, understand?

@ValueRaider
Copy link
Collaborator

ValueRaider commented Jun 24, 2023

Also, note that for non-ETF symbols e..g 'AMZN', major_holdings returns price information instead, doesn't make sense.

@ValueRaider
Copy link
Collaborator

@AKwoKWH Do you plan to complete this?

@dotJoel
Copy link

dotJoel commented Feb 24, 2024

i have a branch that replicates copies and finishes this work.
unless #1784 is the preferred direction.

@ValueRaider
Copy link
Collaborator

@bot-unit

@bot-unit
Copy link

bot-unit commented Feb 25, 2024

@ValueRaider
sorry. i'm busy and cann't help now. I think we can accept any working code for now, and replace it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants