Skip to content

Commit

Permalink
Merge pull request #5499 from rancher-sandbox/run-locked-field-test-o…
Browse files Browse the repository at this point in the history
…n-windows

We can now run locked-field e2e tests on Windows
  • Loading branch information
mook-as authored Sep 13, 2023
2 parents a970979 + 18e8390 commit b72acf1
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions e2e/lockedFields.e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ import { readDeploymentProfiles } from '@pkg/main/deploymentProfiles';
import { spawnFile } from '@pkg/utils/childProcess';
import { reopenLogs } from '@pkg/utils/logging';

import type { ElectronApplication, BrowserContext, Page } from '@playwright/test';
import type { ElectronApplication, Page } from '@playwright/test';

test.describe('Locked fields', () => {
test.skip(process.platform === 'win32', 'TODO: Implement testing on Windows');
let electronApp: ElectronApplication;
let context: BrowserContext;
let page: Page;
const appPath = path.join(__dirname, '../');
let deploymentProfile: DeploymentProfileType|null = null;
Expand Down Expand Up @@ -91,12 +89,6 @@ test.describe('Locked fields', () => {
{ containerEngine: { allowedImages: { enabled: true, patterns: ['c', 'd', 'f'] } }, kubernetes: { version: lockedK8sVersion } },
);
electronApp = await startRancherDesktop(__filename);
context = electronApp.context();

await context.tracing.start({
screenshots: true,
snapshots: true,
});
page = await electronApp.firstWindow();
});

Expand Down

0 comments on commit b72acf1

Please sign in to comment.