Deployment profile testing with BATS #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaSih
reviewed
Jun 20, 2023
jandubois
force-pushed
the
bats-profile
branch
3 times, most recently
from
050187b
to
4a32171
Compare
IsaSih
requested changes
Jun 22, 2023
jandubois
force-pushed
the
bats-profile
branch
3 times, most recently
from
2b7b86e
to
d9c74b1
Compare
IsaSih
requested changes
Jul 6, 2023
jandubois
commented
Jul 6, 2023
There was a problem hiding this comment.
Updated the PR with some of the suggested changes; see replies for the rest.
I also had to update the start_app function in the sample test; not sure why this stopped working. The change is similar to something I did in #5108.
We can later combine it, but once #5104 is merged this may be further simplified again.
jandubois
force-pushed
the
bats-profile
branch
2 times, most recently
from
8bdbbd7
to
1eec7f8
Compare
IsaSih
requested changes
Jul 7, 2023
Signed-off-by: Jan Dubois <[email protected]>
Signed-off-by: Jan Dubois <[email protected]>
"Declare and assign separately to avoid masking return values"
Instead of
local foo=$(bar)
we need to write
local foo
foo=$(bar)
to make sure we throw an error when `bar` returns a non-zero status
Signed-off-by: Jan Dubois <[email protected]>
Changing this to ${FOO-} was done by 3.6.0, but has since been reverted.
See mvdan/sh#970
Signed-off-by: Jan Dubois <[email protected]>
IsaSih
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains both the BATS framework for testing deployment profiles, and a sample test to demonstrate how to use it.
It works for macOS using user profiles. Testing system profiles will require password-less sudo.
The code has not been tested on Windows yet. It is only expected to work for the user-legacy location on Windows; every other location requires admin access and is out of scope for this PR.