Nuxt Removal #5287

rak-phillip · 2023-08-02T22:05:19Z

This follows the same strategy implemented in rancher/dashboard#7211, where we take all of the nuxt generated files and move them into pkg/rancher-desktop/nuxt, and migrate nuxt.config.js to vue.config.js.

In addition to these changes, this PR also installs vue-cli and upgrades Vue to v2.7.14, the latest version of Vue available on the 2.x branch. Making this change allows us to target a single version of typescript (v4.5.6) and resolves any comparability issues that we might have previously encountered. Most notably, no more typescript warnings when installing dependencies.

Finally, the Vue upgrade also includes an update to webpack 5. This introduces some breaking changes, so we need to update our webpack configs to accommodate this.

closes #5000

rak-phillip · 2023-08-03T00:32:30Z

I'm working through errors in ci, but I still think this is in a state where it's ready to start reviewing

rak-phillip · 2023-08-04T17:25:04Z

The only failure at this point is spell check in files that got modified, but none of these typos are new.. I'll work on resolving those.

adamkpickering · 2023-08-04T17:44:33Z

After a git clean -ffdx and yarn install, yarn dev hangs without producing an application window. The following text is printed:

 WARNING  Compiled with 1 warning                                                                                                                                                  11:39:25 AM

 warning  in ./pkg/rancher-desktop/store/prefs.js

Module not found: Error: Can't resolve '~/assets/brand' in '/home/adam/dev/rancher-desktop/pkg/rancher-desktop/store'


  App running at:
  - Local:   http://DESKTOP-PJ3KQUA.lan:8888/
  - Network: http://DESKTOP-PJ3KQUA.lan:8888/

  Note that the development build is not optimized.
  To create a production build, run yarn build.

No issues found.

The Module not found line might be relevant.

I was able to do a yarn build; yarn package and run from the produced build inside dist/linux-unpacked without any issues. Everything I tested appears to work normally. So the issue seems to be with yarn dev only.

This is all on Linux (openSUSE Leap 15.3). I will test on Windows shortly.

rak-phillip · 2023-08-04T18:04:49Z

Module not found: Error: Can't resolve '~/assets/brand' in '/home/adam/dev/rancher-desktop/pkg/rancher-desktop/store'

This is an old issue that exists in our components that we import from Dashboard, so I don't think that's the problem. If you've run e2e tests recently on your workstation, you might want to make sure that there aren't any zombie nuxt processes hanging around, that could be the culprit.

I've been developing primarily on openSUSE Tumbleweed, but I can spin up an openSUSE Leap 15.3 vm to see if there's any change in behavior there.

adamkpickering · 2023-08-04T21:09:56Z

Ok this is weird. The same thing is happening on windows 10: after a reboot and a git clean -ffdx; yarn install, running yarn dev results in the same text and no RD window. No icon in the taskbar either.

rak-phillip · 2023-08-04T21:31:29Z

@adamkpickering can you provide the output of yarn dev so I can inspect?

adamkpickering · 2023-08-04T21:47:19Z

Here is the full output:

rancher-desktop\> yarn dev
yarn run v1.22.19
$ node scripts/ts-wrapper.js scripts/dev.ts
asset preload.js 29.1 KiB [emitted] (name: preload) 1 related asset
runtime modules 2.03 KiB 5 modules
built modules 20.9 KiB [built]
  cacheable modules 20.8 KiB
    modules by path ./pkg/rancher-desktop/preload/*.ts 20.3 KiB
      ./pkg/rancher-desktop/preload/index.ts 168 bytes [built] [code generated]
      ./pkg/rancher-desktop/preload/extensions.ts 20.1 KiB [built] [code generated]
    modules by path ./pkg/rancher-desktop/utils/*.ts 502 bytes
      ./pkg/rancher-desktop/utils/clone.ts 306 bytes [built] [code generated]
      ./pkg/rancher-desktop/utils/ipcRenderer.ts 196 bytes [built] [code generated]
  external "electron" 42 bytes [built] [code generated]
  external "os" 42 bytes [built] [code generated]
webpack 5.88.2 compiled successfully in 32331 ms
$ cross-env VUE_CLI_SERVICE_CONFIG_PATH=pkg/rancher-desktop/vue.config.js vue-cli-service serve --hostname localhost --port 8888
 INFO  Starting development server...
[51%] building (117/329 modules)
asset background.js 1.83 MiB [emitted] (name: background) 1 related asset
asset pkg_rancher-desktop_main_extensions_manager_ts.js 60.5 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_wslFromStore_ts.js 10.6 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_dockerCliSymlinks_ts.js 8.79 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_rdBinInShell_ts.js 7.08 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_limaDarwin_ts.js 5.18 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_connectedToInternet_ts.js 4.92 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_kubeContext_ts.js 3.83 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_testCheckers_ts.js 2.78 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_mockForScreenshots_ts.js 2.67 KiB [emitted] 1 related asset
runtime modules 2.43 KiB 8 modules
modules by path ./node_modules/ 484 KiB
  modules by path ./node_modules/lodash/*.js 147 KiB 195 modules
  modules by path ./node_modules/@kubernetes/client-node/ 88.8 KiB 162 modules
  modules by path ./node_modules/js-yaml/ 108 KiB 25 modules
  modules by path ./node_modules/builder-util-runtime/out/*.js 41.4 KiB 8 modules
  modules by path ./node_modules/electron-updater/out/ 14.6 KiB 5 modules
  modules by path ./node_modules/debug/ 19.8 KiB 5 modules
  + 5 modules
modules by path ./pkg/rancher-desktop/ 823 KiB 128 modules
+ 45 modules


 WARNING  Compiled with 1 warning                                                                                                                                                 3:45:42 p.m.

 warning  in ./pkg/rancher-desktop/store/prefs.js

Module not found: Error: Can't resolve '~/assets/brand' in 'C:\Users\adamk\dev\rancher-desktop\pkg\rancher-desktop\store'


  App running at:
  - Local:   http://localhost:8888/
  - Network: http://192.168.1.143:8888/

  Note that the development build is not optimized.
  To create a production build, run yarn build.

Issues checking in progress...

No issues found.
(node:15812) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
                                                                                                                                                              (Use `electron --trace-deprecation ...` to show where the warning was created)

adamkpickering · 2023-08-04T21:48:18Z

Hold on, looks like it worked that time...

rak-phillip · 2023-08-04T22:06:10Z

I'm thinking there's something going on here, seeing as how you replicated in two different environments. I still need to provision a new vm to test , maybe that can shed some light.

adamkpickering · 2023-08-04T22:35:19Z

I now realize my previous comment wasn't completely accurate: I had run a yarn build; yarn package before the yarn dev. I tried the following procedure:

git clean -ffdx
yarn install
yarn dev

And RD failed to start with the following output:

rancher-desktop\> yarn dev
yarn run v1.22.19
$ node scripts/ts-wrapper.js scripts/dev.ts
asset preload.js 29.1 KiB [emitted] (name: preload) 1 related asset
runtime modules 2.03 KiB 5 modules
built modules 20.9 KiB [built]
  cacheable modules 20.8 KiB
    modules by path ./pkg/rancher-desktop/preload/*.ts 20.3 KiB
      ./pkg/rancher-desktop/preload/index.ts 168 bytes [built] [code generated]
      ./pkg/rancher-desktop/preload/extensions.ts 20.1 KiB [built] [code generated]
    modules by path ./pkg/rancher-desktop/utils/*.ts 502 bytes
      ./pkg/rancher-desktop/utils/clone.ts 306 bytes [built] [code generated]
      ./pkg/rancher-desktop/utils/ipcRenderer.ts 196 bytes [built] [code generated]
  external "electron" 42 bytes [built] [code generated]
  external "os" 42 bytes [built] [code generated]
webpack 5.88.2 compiled successfully in 37316 ms
$ cross-env VUE_CLI_SERVICE_CONFIG_PATH=pkg/rancher-desktop/vue.config.js vue-cli-service serve --hostname localhost --port 8888
 INFO  Starting development server...
asset background.js 1.83 MiB [emitted] (name: background) 1 related asset
asset pkg_rancher-desktop_main_extensions_manager_ts.js 60.5 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_wslFromStore_ts.js 10.6 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_dockerCliSymlinks_ts.js 8.79 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_rdBinInShell_ts.js 7.08 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_limaDarwin_ts.js 5.18 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_connectedToInternet_ts.js 4.92 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_kubeContext_ts.js 3.83 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_testCheckers_ts.js 2.78 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_mockForScreenshots_ts.js 2.67 KiB [emitted] 1 related asset
runtime modules 2.43 KiB 8 modules
modules by path ./node_modules/ 484 KiB
  modules by path ./node_modules/lodash/*.js 147 KiB 195 modules
  modules by path ./node_modules/@kubernetes/client-node/ 88.8 KiB 162 modules
  modules by path ./node_modules/js-yaml/ 108 KiB 25 modules
  modules by path ./node_modules/builder-util-runtime/out/*.js 41.4 KiB 8 modules
  modules by path ./node_modules/electron-updater/out/ 14.6 KiB 5 modules
  modules by path ./node_modules/debug/ 19.8 KiB 5 modules
  + 5 modules
modules by path ./pkg/rancher-desktop/ 823 KiB 128 modules
+ 45 modules
webpack 5.88.2 compiled successfully in 52045 ms
Failure in startMainProcess: FetchError: request to http://localhost:8888/ failed, reason: connect ECONNREFUSED 127.0.0.1:8888


 WARNING  Compiled with 1 warning                                                                                                                                                 4:01:21 p.m.

 warning  in ./pkg/rancher-desktop/store/prefs.js

Module not found: Error: Can't resolve '~/assets/brand' in 'C:\Users\adamk\dev\rancher-desktop\pkg\rancher-desktop\store'


  App running at:
  - Local:   http://localhost:8888/
  - Network: http://192.168.1.143:8888/

  Note that the development build is not optimized.
  To create a production build, run yarn build.

No issues found.

Maybe the Failure in startMainProcess line is relevant? It isn't present in the previous output.

I then tried running yarn build; yarn package, then running yarn dev again. It started up fine and I got the following output:

rancher-desktop\> yarn dev
yarn run v1.22.19
$ node scripts/ts-wrapper.js scripts/dev.ts
asset preload.js 29.1 KiB [emitted] (name: preload) 1 related asset
runtime modules 2.03 KiB 5 modules
built modules 20.9 KiB [built]
  cacheable modules 20.8 KiB
    modules by path ./pkg/rancher-desktop/preload/*.ts 20.3 KiB
      ./pkg/rancher-desktop/preload/index.ts 168 bytes [built] [code generated]
      ./pkg/rancher-desktop/preload/extensions.ts 20.1 KiB [built] [code generated]
    modules by path ./pkg/rancher-desktop/utils/*.ts 502 bytes
      ./pkg/rancher-desktop/utils/clone.ts 306 bytes [built] [code generated]
      ./pkg/rancher-desktop/utils/ipcRenderer.ts 196 bytes [built] [code generated]
  external "electron" 42 bytes [built] [code generated]
  external "os" 42 bytes [built] [code generated]
webpack 5.88.2 compiled successfully in 27723 ms
$ cross-env VUE_CLI_SERVICE_CONFIG_PATH=pkg/rancher-desktop/vue.config.js vue-cli-service serve --hostname localhost --port 8888
 INFO  Starting development server...
[51%] building (208/569 modules)
asset background.js 1.83 MiB [emitted] (name: background) 1 related asset
asset pkg_rancher-desktop_main_extensions_manager_ts.js 60.5 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_wslFromStore_ts.js 10.6 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_dockerCliSymlinks_ts.js 8.79 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_rdBinInShell_ts.js 7.08 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_limaDarwin_ts.js 5.18 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_connectedToInternet_ts.js 4.92 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_kubeContext_ts.js 3.83 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_testCheckers_ts.js 2.78 KiB [emitted] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_mockForScreenshots_ts.js 2.67 KiB [emitted] 1 related asset
runtime modules 2.43 KiB 8 modules
modules by path ./node_modules/ 484 KiB
  modules by path ./node_modules/lodash/*.js 147 KiB 195 modules
  modules by path ./node_modules/@kubernetes/client-node/ 88.8 KiB 162 modules
  modules by path ./node_modules/js-yaml/ 108 KiB 25 modules
  modules by path ./node_modules/builder-util-runtime/out/*.js 41.4 KiB 8 modules
  modules by path ./node_modules/electron-updater/out/ 14.6 KiB 5 modules
  modules by path ./node_modules/debug/ 19.8 KiB 5 modules
  + 5 modules
modules by path ./pkg/rancher-desktop/ 823 KiB 128 modules
+ 45 modules


 WARNING  Compiled with 1 warning                                                                                                                                                 4:19:41 p.m.

 warning  in ./pkg/rancher-desktop/store/prefs.js

Module not found: Error: Can't resolve '~/assets/brand' in 'C:\Users\adamk\dev\rancher-desktop\pkg\rancher-desktop\store'


  App running at:
  - Local:   http://localhost:8888/
  - Network: http://192.168.1.143:8888/

  Note that the development build is not optimized.
  To create a production build, run yarn build.

Issues checking in progress...

No issues found.
(node:10732) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
                                                                                                                                                              (Use `electron --trace-deprecation ...` to show where the warning was created)

Finally I did the following procedure, to check whether yarn dev doesn't just work the second time without yarn build; yarn package:

git clean -ffdx
yarn install
yarn dev, wait for it to finish building etc and then ctrl-C
yarn dev

Lo and behold, it worked on step 4 with the following output:

rancher-desktop\> yarn dev
yarn run v1.22.19
$ node scripts/ts-wrapper.js scripts/dev.ts
asset preload.js 29.1 KiB [compared for emit] (name: preload) 1 related asset
runtime modules 2.03 KiB 5 modules
built modules 20.9 KiB [built]
  cacheable modules 20.8 KiB
    modules by path ./pkg/rancher-desktop/preload/*.ts 20.3 KiB
      ./pkg/rancher-desktop/preload/index.ts 168 bytes [built] [code generated]
      ./pkg/rancher-desktop/preload/extensions.ts 20.1 KiB [built] [code generated]
    modules by path ./pkg/rancher-desktop/utils/*.ts 502 bytes
      ./pkg/rancher-desktop/utils/clone.ts 306 bytes [built] [code generated]
      ./pkg/rancher-desktop/utils/ipcRenderer.ts 196 bytes [built] [code generated]
  external "electron" 42 bytes [built] [code generated]
  external "os" 42 bytes [built] [code generated]
webpack 5.88.2 compiled successfully in 27661 ms
$ cross-env VUE_CLI_SERVICE_CONFIG_PATH=pkg/rancher-desktop/vue.config.js vue-cli-service serve --hostname localhost --port 8888
 INFO  Starting development server...
[51%] building (208/554 modules)
asset background.js 1.83 MiB [compared for emit] (name: background) 1 related asset
asset pkg_rancher-desktop_main_extensions_manager_ts.js 60.5 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_wslFromStore_ts.js 10.6 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_dockerCliSymlinks_ts.js 8.79 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_rdBinInShell_ts.js 7.08 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_limaDarwin_ts.js 5.18 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_connectedToInternet_ts.js 4.92 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_kubeContext_ts.js 3.83 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_testCheckers_ts.js 2.78 KiB [compared for emit] 1 related asset
asset pkg_rancher-desktop_main_diagnostics_mockForScreenshots_ts.js 2.67 KiB [compared for emit] 1 related asset
runtime modules 2.43 KiB 8 modules
modules by path ./node_modules/ 484 KiB
  modules by path ./node_modules/lodash/*.js 147 KiB 195 modules
  modules by path ./node_modules/@kubernetes/client-node/ 88.8 KiB 162 modules
  modules by path ./node_modules/js-yaml/ 108 KiB 25 modules
  modules by path ./node_modules/builder-util-runtime/out/*.js 41.4 KiB 8 modules
  modules by path ./node_modules/electron-updater/out/ 14.6 KiB 5 modules
  modules by path ./node_modules/debug/ 19.8 KiB 5 modules
  + 5 modules
modules by path ./pkg/rancher-desktop/ 823 KiB 128 modules
+ 45 modules


 WARNING  Compiled with 1 warning                                                                                                                                                 4:33:26 p.m.

 warning  in ./pkg/rancher-desktop/store/prefs.js

Module not found: Error: Can't resolve '~/assets/brand' in 'C:\Users\adamk\dev\rancher-desktop\pkg\rancher-desktop\store'


  App running at:
  - Local:   http://localhost:8888/
  - Network: http://192.168.1.143:8888/

  Note that the development build is not optimized.
  To create a production build, run yarn build.

Issues checking in progress...

No issues found.

And, I can't see any error messages in that last block of text. Maybe something is being built out of order?

rak-phillip · 2023-08-05T14:07:38Z

It does seem to be the case that something is being built out of order. You have the following line in your first example:

Failure in startMainProcess: FetchError: request to http://localhost:8888/ failed, reason: connect ECONNREFUSED 127.0.0.1:8888

This is raised long before the frontend dev server is ready, so this is telling us that the backend is starting alongside the frontend. I saw something similar with e2e tests as well, but I'm mighty curious as to why our spawn wrapper is executing out of sequence.

rak-phillip · 2023-08-07T16:55:28Z

@adamkpickering I made some modifications to the dev script to

Move the wait for the vue dev server to start inside of startRendererProcess
Allow the fetch to renderer.home to fail while the dev server is starting
Retry checking for the vue dev server while it is starting

Can you test this and let me know if the change resolves your issue?

adamkpickering · 2023-08-08T16:42:17Z

I tried it, and got a new error:

rancher-desktop/> yarn dev
yarn run v1.22.19
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.
$ node scripts/ts-wrapper.js scripts/dev.ts
asset preload.js 28.6 KiB [emitted] (name: preload) 1 related asset
runtime modules 2.03 KiB 5 modules
built modules 20.4 KiB [built]
  cacheable modules 20.3 KiB
    modules by path ./pkg/rancher-desktop/preload/*.ts 19.9 KiB
      ./pkg/rancher-desktop/preload/index.ts 157 bytes [built] [code generated]
      ./pkg/rancher-desktop/preload/extensions.ts 19.7 KiB [built] [code generated]
    modules by path ./pkg/rancher-desktop/utils/*.ts 487 bytes
      ./pkg/rancher-desktop/utils/clone.ts 297 bytes [built] [code generated]
      ./pkg/rancher-desktop/utils/ipcRenderer.ts 190 bytes [built] [code generated]
  external "electron" 42 bytes [built] [code generated]
  external "os" 42 bytes [built] [code generated]
webpack 5.88.2 compiled successfully in 11820 ms
Renderer process: starting...
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.
$ cross-env VUE_CLI_SERVICE_CONFIG_PATH=pkg/rancher-desktop/vue.config.js vue-cli-service serve --hostname localhost --port 8888
 INFO  Starting development server...
[51%] building (250/852 modules)
Error: Renderer build failed to connect after 10 attempts
    at Timeout.<anonymous> (/home/adam/dev/rancher-desktop/scripts/dev.ts:156:20)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
/home/adam/dev/rancher-desktop/scripts/dev.ts:27
    const newError: Error & { code?: number } = new Error(combinedMessage);
                                                ^
Error: Renderer process error: Process exited with code 1
    at DevRunner.emitError (/home/adam/dev/rancher-desktop/scripts/dev.ts:27:49)
    at /home/adam/dev/rancher-desktop/scripts/dev.ts:52:28
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Caused by: Error: Process exited with code 1
    at ChildProcess.<anonymous> (/home/adam/dev/rancher-desktop/scripts/lib/build-utils.ts:96:18)
    at ChildProcess.emit (node:events:525:35)
    at ChildProcess.emit (node:domain:489:12)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12) {
  code: undefined
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

rak-phillip · 2023-08-08T16:49:17Z

@adamkpickering okay, that's better.

Error: Renderer build failed to connect after 10 attempts

This at least tells me that it's failing exactly where I originally thought that it would. I can try to tweak this so that we can delay the time that it takes to fail.

rak-phillip · 2023-08-08T20:03:44Z

@adamkpickering ready for another attempt when you're ready.

Invoke vue cli for build scripts Signed-off-by: Phillip Rak <[email protected]>

Remove vue cli eslint plugin, as we should defer to linting via scripts defined in `package.json` Signed-off-by: Phillip Rak <[email protected]>

Signed-off-by: Phillip Rak <[email protected]>

Rename `startRendererProcess` to `buildRenderer` Signed-off-by: Phillip Rak <[email protected]>

Signed-off-by: Phillip Rak <[email protected]>

Fix lint errors Signed-off-by: Phillip Rak <[email protected]>

Signed-off-by: Phillip Rak <[email protected]>

rak-phillip · 2023-09-20T21:37:41Z

The changes look fine now. But it may need a rebase, I can't start with:

<Nav> error: path "/Containers" not found in routes ["/DenyRoot","/Diagnostics","/Dialog","/Extensions","/FirstRun","/General","/Images","/KubernetesError","/PortForwarding","/Preferences","/SudoPrompt","/Troubleshooting","/UnmetPrerequisites","/extensions/installed","/images/add","/images/scans/:image-name?","/extensions/:root?/:src?/:id?","/extensions/:root(.*)/:src/:id"]

Yeah, this error is directly related to merging #5258. This PR has been rebased and updated to accommodate the new Containers route.

ericpromislow

Everything passed for me on all three platforms, and the current changeset looks fine.

rak-phillip requested review from ericpromislow and adamkpickering August 2, 2023 22:22

rak-phillip force-pushed the feature/5000-nuxt-removal-functioning branch from 17bd539 to 538b315 Compare August 2, 2023 22:30

rak-phillip marked this pull request as ready for review August 2, 2023 22:31

rak-phillip marked this pull request as draft August 3, 2023 17:47

rak-phillip force-pushed the feature/5000-nuxt-removal-functioning branch 6 times, most recently from cba2dc8 to 31ece93 Compare August 4, 2023 15:50

rak-phillip marked this pull request as ready for review August 4, 2023 17:24

rak-phillip mentioned this pull request Aug 4, 2023

Update eslint to latest and (8.39.0) and fix vue linting errors #5298

Closed

rak-phillip force-pushed the feature/5000-nuxt-removal-functioning branch from c59a29a to e91c0f5 Compare August 7, 2023 17:41

rak-phillip force-pushed the feature/5000-nuxt-removal-functioning branch from 85d4a3c to 4f8ecb4 Compare August 8, 2023 21:32

rak-phillip added 21 commits September 20, 2023 14:29

Invoke vue cli directly for dev scripts

f609564

Invoke vue cli for build scripts Signed-off-by: Phillip Rak <[email protected]>

Utilize .gitignore instead of .eslint ignore

5cfc076

Remove vue cli eslint plugin, as we should defer to linting via scripts defined in `package.json` Signed-off-by: Phillip Rak <[email protected]>

Update location of import/namespace rule

c6d5962

Signed-off-by: Phillip Rak <[email protected]>

Update exclude rules for spell check

ae234b3

Signed-off-by: Phillip Rak <[email protected]>

Utilize build utils for spawning e2e build

7cb4fd7

Rename `startRendererProcess` to `buildRenderer` Signed-off-by: Phillip Rak <[email protected]>

Clean up index.html

45969ab

Signed-off-by: Phillip Rak <[email protected]>

Remove unused build flags

7d5dbf4

Signed-off-by: Phillip Rak <[email protected]>

Ignore eslint plugin for vue-cli

d9029c9

Signed-off-by: Phillip Rak <[email protected]>

Remove mode specification in vue.config

9f7f52e

Signed-off-by: Phillip Rak <[email protected]>

Fix lint errors

68f45f5

Fix lint errors Signed-off-by: Phillip Rak <[email protected]>

Determine if renderer uses a dev build

29458bc

Signed-off-by: Phillip Rak <[email protected]>

Add MIT license for nuxt directory

067f9e2

Signed-off-by: Phillip Rak <[email protected]>

Remove dev dep @types/webpack

b56cf98

Signed-off-by: Phillip Rak <[email protected]>

Disable import/namespace for extensions preload

4b681e3

Signed-off-by: Phillip Rak <[email protected]>

Remove ~/* path from tsconfig

6c3067c

Signed-off-by: Phillip Rak <[email protected]>

Comment on eslint disable usage

9d0862c

Signed-off-by: Phillip Rak <[email protected]>

Add catch method to initial call to checkDevServer()

19ba3e9

Signed-off-by: Phillip Rak <[email protected]>

Remove explicit types in build-utils.ts

47a1967

Signed-off-by: Phillip Rak <[email protected]>

Move eslint ignore closer to problematic code

a08619d

Signed-off-by: Phillip Rak <[email protected]>

Remove wait helper

9b2a3a3

Signed-off-by: Phillip Rak <[email protected]>

Update router to include new containers page

b1b4b49

Signed-off-by: Phillip Rak <[email protected]>

rak-phillip force-pushed the feature/5000-nuxt-removal-functioning branch from 8d8b121 to b1b4b49 Compare September 20, 2023 21:36

rak-phillip requested a review from mook-as September 20, 2023 21:37

mook-as approved these changes Sep 20, 2023

View reviewed changes

ericpromislow approved these changes Sep 21, 2023

View reviewed changes

ericpromislow merged commit 853b0cc into rancher-sandbox:main Sep 21, 2023
10 checks passed

rak-phillip mentioned this pull request Oct 10, 2023

Incorrect Window Titles Displayed #5699

Closed

This was referenced Oct 24, 2023

No spacing for project links on General Page #5824

Closed

Add spacing to project links on general page #5825

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nuxt Removal #5287

Nuxt Removal #5287

rak-phillip commented Aug 2, 2023 •

edited

Loading

rak-phillip commented Aug 3, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 5, 2023 •

edited

Loading

rak-phillip commented Aug 7, 2023

adamkpickering commented Aug 8, 2023

rak-phillip commented Aug 8, 2023

rak-phillip commented Aug 8, 2023

rak-phillip commented Sep 20, 2023

ericpromislow left a comment

Nuxt Removal #5287

Nuxt Removal #5287

Conversation

rak-phillip commented Aug 2, 2023 • edited Loading

rak-phillip commented Aug 3, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 4, 2023

adamkpickering commented Aug 4, 2023

rak-phillip commented Aug 5, 2023 • edited Loading

rak-phillip commented Aug 7, 2023

adamkpickering commented Aug 8, 2023

rak-phillip commented Aug 8, 2023

rak-phillip commented Aug 8, 2023

rak-phillip commented Sep 20, 2023

ericpromislow left a comment

Choose a reason for hiding this comment

rak-phillip commented Aug 2, 2023 •

edited

Loading

rak-phillip commented Aug 5, 2023 •

edited

Loading