Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuxt Removal #5287

Merged
merged 41 commits into from
Sep 21, 2023
Merged

Nuxt Removal #5287

merged 41 commits into from
Sep 21, 2023

Commits on Sep 20, 2023

  1. Create snapshot of the nuxt directory 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3d4a4b6 View commit details
    Browse the repository at this point in the history

  2. Introduce vue-cli and replace nuxt.config with vue.config 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    606313e View commit details
    Browse the repository at this point in the history

  3. Fix lint errors 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    037ace7 View commit details
    Browse the repository at this point in the history

  4. Resolve jest downgrade errors 

    Jest was downgraded to accommodate dependency requirements for vue-cli. This downgrade from 29.5.0 to 27.5.1 means that we won't have access to `jest.ReplaceProperty`, so we have to put in some more effort to mock our resources.

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f79ddc3 View commit details
    Browse the repository at this point in the history

  5. Resolve issues with JSX.Element 

    Vue 2.7.14 enabled jsx by default, this unfortunately introduces a conflict with the types provided through our tooling and the custom Element used in `installer-win32-gen.tsx`. Temporarily ignoring areas that experience the type conflicts in `installer-win32-gen.tsx` helps to resolve this issue for now.

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0624d13 View commit details
    Browse the repository at this point in the history

  6. Update webpack preload config 

    Updating to Vue 2.7.14 also updated webpack to v5.88.2. This update was a breaking change and requires updating our configs to retain compatibility.

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7ecac46 View commit details
    Browse the repository at this point in the history

  7. Resolve Vue warnings 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    56c0dc9 View commit details
    Browse the repository at this point in the history

  8. Update build script 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9a3422e View commit details
    Browse the repository at this point in the history

  9. Update dependencies for unit tests 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    cd40f39 View commit details
    Browse the repository at this point in the history

  10. Upgrade jest dependencies and fix dockerCliSymlink test 

    Remove unused eslint statements
Fix eslint import order
Revert changes to `appDir`

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    aa43007 View commit details
    Browse the repository at this point in the history

  11. Update e2e script 

    Update e2e script

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    22fbfc9 View commit details
    Browse the repository at this point in the history

  12. Wait for build before running e2e tests 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2b291ec View commit details
    Browse the repository at this point in the history

  13. Use cross-spawn for cross platform scripts 

    We are implementing cross-spawn to deal with errors when scripting vue-cli commands on Windows. Cross-spawn helps us spawn child processes in our dev scripts consistently on Windows, macOS, and Linux.

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d8fe19e View commit details
    Browse the repository at this point in the history

  14. Remove routes.json 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f1be5a6 View commit details
    Browse the repository at this point in the history

  15. Ignore spelling under pkg/rancher-desktop/nuxt 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5ae1f89 View commit details
    Browse the repository at this point in the history

  16. Update list of expected words 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ca8f1a6 View commit details
    Browse the repository at this point in the history

  17. Wait for vue dev server 

    Allow dev server fetch to fail
Fix import
Add some console info to dev scripts

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4396e0c View commit details
    Browse the repository at this point in the history

  18. Expect Ssr 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7101a1c View commit details
    Browse the repository at this point in the history

  19. Poll with setTimeout instead of setInterval 

    Use `--host` argument instead of `--hostname`
Increase number of retries to 30

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c7ad0aa View commit details
    Browse the repository at this point in the history

  20. Remove ignore comment 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d08987d View commit details
    Browse the repository at this point in the history

  21. Invoke vue cli directly for dev scripts 

    Invoke vue cli for build scripts

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f609564 View commit details
    Browse the repository at this point in the history

  22. Utilize .gitignore instead of .eslint ignore 

    Remove vue cli eslint plugin, as we should defer to linting via scripts defined in `package.json`

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5cfc076 View commit details
    Browse the repository at this point in the history

  23. Update location of import/namespace rule 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c6d5962 View commit details
    Browse the repository at this point in the history

  24. Update exclude rules for spell check 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ae234b3 View commit details
    Browse the repository at this point in the history

  25. Utilize build utils for spawning e2e build 

    Rename `startRendererProcess` to `buildRenderer`

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7cb4fd7 View commit details
    Browse the repository at this point in the history

  26. Clean up index.html 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    45969ab View commit details
    Browse the repository at this point in the history

  27. Remove unused build flags 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7d5dbf4 View commit details
    Browse the repository at this point in the history

  28. Ignore eslint plugin for vue-cli 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d9029c9 View commit details
    Browse the repository at this point in the history

  29. Remove mode specification in vue.config 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9f7f52e View commit details
    Browse the repository at this point in the history

  30. Fix lint errors 

    Fix lint errors

Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    68f45f5 View commit details
    Browse the repository at this point in the history

  31. Determine if renderer uses a dev build 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    29458bc View commit details
    Browse the repository at this point in the history

  32. Add MIT license for nuxt directory 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    067f9e2 View commit details
    Browse the repository at this point in the history

  33. Remove dev dep @types/webpack 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b56cf98 View commit details
    Browse the repository at this point in the history

  34. Disable import/namespace for extensions preload 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4b681e3 View commit details
    Browse the repository at this point in the history

  35. Remove ~/* path from tsconfig 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    6c3067c View commit details
    Browse the repository at this point in the history

  36. Comment on eslint disable usage 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9d0862c View commit details
    Browse the repository at this point in the history

  37. Add catch method to initial call to checkDevServer() 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    19ba3e9 View commit details
    Browse the repository at this point in the history

  38. Remove explicit types in build-utils.ts 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    47a1967 View commit details
    Browse the repository at this point in the history

  39. Move eslint ignore closer to problematic code 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a08619d View commit details
    Browse the repository at this point in the history

  40. Remove wait helper 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9b2a3a3 View commit details
    Browse the repository at this point in the history

  41. Update router to include new containers page 

    Signed-off-by: Phillip Rak <[email protected]>
    @rak-phillip
    rak-phillip committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b1b4b49 View commit details
    Browse the repository at this point in the history