Guest agent: Add comment about host address #7557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this clears up confusion about what the HostIP refers to. Signed-off-by: Mark Yen <[email protected]>
mook-as
force-pushed
the
guestagent-hostip-clarification
branch
from
3f88597
to
7ffb6e2
Compare
Nino-K
approved these changes
Sep 27, 2024
| @@ -23,9 +23,12 @@ import "github.com/docker/go-connections/nat" | |||
| type PortMapping struct { | |||
| // Remove indicates whether the port mappings should be removed (true) or added (false) | |||
| Remove bool `json:"remove"` | |||
| // Ports contains the port mappings for both IPv4 and IPv6 addresses | |||
| // Ports contains the port mappings for both IPv4 and IPv6 addresses. The host address | |||
There was a problem hiding this comment.
Just to clarify, the term "host" always refers to the actual host machine, such as a Windows machine, and cannot mean anything else. If there's any confusion regarding the host being interpreted as a previous network hop—like a namespace network, that would be the upstream/downstream address.
|
I think linter is failing though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this clears up confusion about what the HostIP refers to.