Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guest agent: Add comment about host address #7557

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Guest agent: Add comment about host address #7557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/go/guestagent/pkg/types/portmapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,12 @@ import "github.com/docker/go-connections/nat"
type PortMapping struct {
// Remove indicates whether the port mappings should be removed (true) or added (false)
Remove bool `json:"remove"`
// Ports contains the port mappings for both IPv4 and IPv6 addresses
// Ports contains the port mappings for both IPv4 and IPv6 addresses. The host address
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, the term "host" always refers to the actual host machine, such as a Windows machine, and cannot mean anything else. If there's any confusion regarding the host being interpreted as a previous network hop—like a namespace network, that would be the upstream/downstream address.

// listed refers to the machine running the VM, i.e. the Windows machine.
Ports nat.PortMap `json:"ports"`
// ConnectAddrs lists the backend addresses for connections
// ConnectAddrs lists the backend addresses for connections; the addresses are recorded
// in terms of the network namespace the container engine is running in (i.e. the
// "Rancher Desktop" network namespace).
ConnectAddrs []ConnectAddrs `json:"connectAddrs"`
}

Expand Down
Loading