Replace beforeDestroy
lifecycle option with beforeUnmount
#12296
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces any remaining
beforeDestroy
lifecycle options withbeforeDestroy
, as mentioned in the Vue 3 migration guide[^1]. This change should also properly clean up the metrics poller, resolving the attached issue.Fixes #12292
Occurred changes and/or fixed issues
beforeDestroy
lifecycle option withbeforeUnmount
Technical notes summary
I searched for instances of
destroyed
in Dashboard, but did not find any. I'm not aware of any other lifecycle options that would need to update at this point.Areas or cases that should be tested
A lot of these lifecycle hooks are used in mixins. There's a good example to test in the associated issue, but also consider testing
Areas which could experience regressions
This should be fixing regressions in each of the affected areas, as
beforeDestroy
is no longer a valid hook.Checklist