Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace beforeDestroy lifecycle option with beforeUnmount #12296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 18, 2024

Summary

This replaces any remaining beforeDestroy lifecycle options with beforeDestroy, as mentioned in the Vue 3 migration guide[^1]. This change should also properly clean up the metrics poller, resolving the attached issue.

Fixes #12292

Occurred changes and/or fixed issues

  • Replace beforeDestroy lifecycle option with beforeUnmount

Technical notes summary

I searched for instances of destroyed in Dashboard, but did not find any. I'm not aware of any other lifecycle options that would need to update at this point.

Areas or cases that should be tested

A lot of these lifecycle hooks are used in mixins. There's a good example to test in the associated issue, but also consider testing

  • Sortable Table
  • Resource Fetch
  • Browser Tab Visibility

Areas which could experience regressions

This should be fixing regressions in each of the affected areas, as beforeDestroy is no longer a valid hook.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.10.0 milestone Oct 18, 2024
@rak-phillip rak-phillip self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster Explorer: Nodes: Error thrown after navigating away from the nodes details page
1 participant