Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace beforeDestroy lifecycle option with beforeUnmount #12296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/components/SortableTable/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default {
};
},

beforeDestroy() {
beforeUnmount() {
window.removeEventListener('resize', this.onWindowResize);
},

Expand Down
2 changes: 1 addition & 1 deletion shell/components/SortableTable/selection.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default {
table.addEventListener('contextmenu', this._onRowContextBound);
},

beforeDestroy() {
beforeUnmount() {
const table = this.$el.querySelector('TABLE');

table.removeEventListener('click', this._onRowClickBound);
Expand Down
2 changes: 1 addition & 1 deletion shell/mixins/browser-tab-visibility.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {
mounted() {
this.setTabVisibilityListener(true);
},
beforeDestroy() {
beforeUnmount() {
this.setTabVisibilityListener(false);
},
};
2 changes: 1 addition & 1 deletion shell/mixins/metric-poller.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default {
this.metricPoller.start();
},

beforeDestroy() {
beforeUnmount() {
this.metricPoller.stop();
},
};
2 changes: 1 addition & 1 deletion shell/mixins/resource-fetch.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default {
};
},

beforeDestroy() {
beforeUnmount() {
// make sure this only runs once, for the initialized instance
if (this.init) {
// clear up the store to make sure we aren't storing anything that might interfere with the next rendered list view
Expand Down
Loading