Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.4 #19767

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Support Ruby 3.4 #19767

merged 1 commit into from
Jan 6, 2025

Conversation

adfoster-r7
Copy link
Contributor

Support Ruby 3.4 - https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/

Verification

Ensure CI passes

@dwelch-r7
Copy link
Contributor

Not an issue for this PR but just to make a note of it when running framework with ruby 3.4.0 we get a handful of warnings

$ ./msfconsole -q                                                                                                                                                        ‹ruby-3.4.0@metasploit-framework›
/Users/dwelch/dev/metasploit-framework/config/application.rb:1: warning: /Users/dwelch/.rvm/rubies/ruby-3.4.0/lib/ruby/3.4.0+1/fiddle.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add fiddle to your Gemfile or gemspec to silence this warning.
/Users/dwelch/.rvm/gems/ruby-3.4.0@metasploit-framework/gems/activesupport-7.0.8.6/lib/active_support/core_ext/benchmark.rb:3: warning: /Users/dwelch/.rvm/rubies/ruby-3.4.0/lib/ruby/3.4.0+1/benchmark.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add benchmark to your Gemfile or gemspec to silence this warning.
/Users/dwelch/.rvm/gems/ruby-3.4.0@metasploit-framework/gems/pry-0.14.2/lib/pry/command_state.rb:3: warning: /Users/dwelch/.rvm/rubies/ruby-3.4.0/lib/ruby/3.4.0+1/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of pry-0.14.2 to request adding ostruct into its gemspec.

@dwelch-r7 dwelch-r7 merged commit e801720 into rapid7:master Jan 6, 2025
82 checks passed
@dwelch-r7 dwelch-r7 added the rn-enhancement release notes enhancement label Jan 6, 2025
@dwelch-r7
Copy link
Contributor

Release Notes

Add support for ruby 3.4.0

@adfoster-r7
Copy link
Contributor Author

Cheers - created a new PR for those gems to be included explicitly #19792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants