Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional library dependencies for Ruby 3.4 support #19792

Conversation

adfoster-r7
Copy link
Contributor

Continuation of #19767

Add additional library dependencies for Ruby 3.4 support

Fixes the following warnings:

$ ./msfconsole -q                                                                                                                                                        ‹ruby-3.4.0@metasploit-framework›
/Users/dwelch/dev/metasploit-framework/config/application.rb:1: warning: /Users/dwelch/.rvm/rubies/ruby-3.4.0/lib/ruby/3.4.0+1/fiddle.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add fiddle to your Gemfile or gemspec to silence this warning.
/Users/dwelch/.rvm/gems/ruby-3.4.0@metasploit-framework/gems/activesupport-7.0.8.6/lib/active_support/core_ext/benchmark.rb:3: warning: /Users/dwelch/.rvm/rubies/ruby-3.4.0/lib/ruby/3.4.0+1/benchmark.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add benchmark to your Gemfile or gemspec to silence this warning.
/Users/dwelch/.rvm/gems/ruby-3.4.0@metasploit-framework/gems/pry-0.14.2/lib/pry/command_state.rb:3: warning: /Users/dwelch/.rvm/rubies/ruby-3.4.0/lib/ruby/3.4.0+1/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of pry-0.14.2 to request adding ostruct into its gemspec.

Verification

  • Ensure CI passes
  • Ensure there are no warnings when opening msfconsole with Ruby 3.4:
$ bundle exec ./msfconsole -q                                              
msf6 auxiliary(scanner/http/title) > 

@adfoster-r7 adfoster-r7 mentioned this pull request Jan 6, 2025
Copy link
Contributor

@sjanusz-r7 sjanusz-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

/Users/x/.rvm/gems/ruby-3.4.0-preview1/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30: warning: /Users/x/.rvm/rubies/ruby-3.4.0-preview1/lib/ruby/3.4.0+0/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec.

After:
No warning

@adfoster-r7 adfoster-r7 merged commit dac7c39 into rapid7:master Jan 7, 2025
82 checks passed
@adfoster-r7 adfoster-r7 deleted the update-add-additional-library-dependencies-for-ruby-3.4-support branch January 7, 2025 12:36
@adfoster-r7
Copy link
Contributor Author

Release Notes

Add additional library dependencies for Ruby 3.4 support

@adfoster-r7 adfoster-r7 added the rn-enhancement release notes enhancement label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants