Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin Sphinx below 8.2.0 #155

Open
18 of 24 tasks
jameslamb opened this issue Feb 21, 2025 · 2 comments
Open
18 of 24 tasks

pin Sphinx below 8.2.0 #155

jameslamb opened this issue Feb 21, 2025 · 2 comments
Assignees

Comments

@jameslamb
Copy link
Member

jameslamb commented Feb 21, 2025

Description

Sphinx 8.2.0 was released recently (release notes). nbsphinx is not compatible with it, and so some docs builds across RAPIDS started breaking like this:

AttributeError: module 'sphinx.util' has no attribute 'console'

...

sphinx.errors.ExtensionError: Handler <function html_collect_pages at 0x7f66eddf6a20> for event 'html-collect-pages' threw an exception (exception: module 'sphinx.util' has no attribute 'console')

(example build link from rmm)

That's been reported in spatialaudio/nbsphinx#825

And there are some proposed upstream fixes:

But to unblock RAPIDS CI, this issue documents the work of pinning to an older sphinx until that upstream issue is resolved.

Benefits of this work

  • unblocks RAPIDS CI

Acceptance Criteria

  • docs builds are running successfully across RAPIDS

Approach

(GitHub task lists are going away 😭 )

@jameslamb jameslamb self-assigned this Feb 21, 2025
@bdice
Copy link
Contributor

bdice commented Feb 21, 2025

@jameslamb Let's filter this to only pin sphinx for repositories using nbsphinx. Here is a list:

https://github.com/search?q=org%3Arapidsai+%2F-+nbsphinx%2F+path%3Adependencies.yaml&type=code

@jameslamb
Copy link
Member Author

It's even narrower than that. For example cudf uses nbsphinx but its docs builds are succeeding with sphinx 8.2.0:

https://github.com/rapidsai/cudf/actions/runs/13446743133/job/37575505715?pr=18058#step:10:6197

That list in the issue isn't a list of repos to change, it's a list of repos to check. I'm not just going to blanket-update them for places that don't need it, I promise.

rapids-bot bot pushed a commit to rapidsai/cugraph-docs that referenced this issue Feb 21, 2025
Contributes to rapidsai/build-planning#155

Fixes docs builds by temporarily putting a ceiling on `sphinx`.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Don Acosta (https://github.com/acostadon)

URL: #100
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this issue Feb 21, 2025
Contributes to rapidsai/build-planning#155

Fixes docs builds by temporarily putting a ceiling on `sphinx`.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #665
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this issue Feb 21, 2025
Contributes to rapidsai/build-planning#155

Fixes docs builds by temporarily putting a ceiling on `sphinx`.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #840
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this issue Feb 21, 2025
Contributes to rapidsai/build-planning#155

Fixes docs builds by temporarily putting a ceiling on `sphinx`.

## Notes for Reviewers

In case you're wondering why you don't see `dependencies.yaml` changes... this project uses readthedocs to builds its docs.

* builds: https://app.readthedocs.org/projects/ucx-py/builds/
* config: https://github.com/rapidsai/ucx-py/blob/674e731c21e3a85045239a943248b23dab019619/.readthedocs.yml#L16-L17

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants