Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require sphinx<8.2.0 #665

Merged
merged 2 commits into from
Feb 21, 2025
Merged

require sphinx<8.2.0 #665

merged 2 commits into from
Feb 21, 2025

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#155

Fixes docs builds by temporarily putting a ceiling on sphinx.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 21, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 21, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@github-actions github-actions bot added the conda label Feb 21, 2025
@jameslamb jameslamb mentioned this pull request Feb 21, 2025
Open
24 tasks
@jameslamb jameslamb changed the title WIP: require sphinx<8.2.0 require sphinx<8.2.0 Feb 21, 2025
@jameslamb jameslamb marked this pull request as ready for review February 21, 2025 17:52
@jameslamb jameslamb requested a review from a team as a code owner February 21, 2025 17:52
@jameslamb jameslamb requested a review from bdice February 21, 2025 17:52
bdice
bdice approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to use a lower bound of >8 to match other repos.

@jameslamb
Copy link
Member Author

We might want to use a lower bound of >8 to match other repos.

Sure, that's fine. Just pushed 85256b5 with that change.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 9922fb4 into rapidsai:branch-25.04 Feb 21, 2025
33 of 34 checks passed
@jameslamb jameslamb deleted the sphinx-pin branch February 21, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice