Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require sphinx<8.2.0, update CODEOWNERS #100

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#155

Fixes docs builds by temporarily putting a ceiling on sphinx.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 21, 2025
@jameslamb jameslamb changed the title WIP: require sphinx<8.2.0 require sphinx<8.2.0 Feb 21, 2025
@jameslamb jameslamb marked this pull request as ready for review February 21, 2025 17:46
@jameslamb jameslamb requested a review from a team as a code owner February 21, 2025 17:50
@jameslamb
Copy link
Member Author

0 reviewers were automatically added by this PR touching dependencies.yaml. I just pushed some CODEOWNERS changes to resolve that.

Intentionally NOT adding the verify-codeowners hook (like rapidsai/cugraph#4900), because it generates rules that aren't relevant for this repo, like for a cpp/ directory.

@jameslamb jameslamb changed the title require sphinx<8.2.0 require sphinx<8.2.0, update CODEOWNERS Feb 21, 2025
@jameslamb jameslamb requested a review from acostadon February 21, 2025 17:51
hooks:
- id: verify-alpha-spec
- id: verify-copyright

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add the hook for codeowners here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

I did not: #100 (comment)

But this is leftover from when I'd attempted that before, and I definitely did not mean to add a new blank line.

Copy link

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit deacf66 into rapidsai:branch-25.04 Feb 21, 2025
8 of 9 checks passed
@jameslamb jameslamb deleted the sphinx-pin branch February 21, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants