Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mock HostWorkspaceServices as early as possible #111

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

tcx4c70
Copy link
Contributor

@tcx4c70 tcx4c70 commented Aug 17, 2023

Mock HostWorkspaceServices as early as possible to make sure that document.Project.Solution.Workspace.Services and document.Project.Solution.Services.WorkspaceServices are the same object (to make sure that both of them are mocked).

Fixes #103.

Mock HostWorkspaceServices as early as possible to make sure that
`document.Project.Solution.Workspace.Services` and
`document.Project.Solution.Services.WorkspaceServices` are the same
object (to make sure that both of them are mocked).

Fixes razzmatazz#103.

Signed-off-by: Adam Tao <[email protected]>
@razzmatazz
Copy link
Owner

OMG thank you! I was trying to fix this some time ago, but didn't give it enough effort

Verified to be working

@razzmatazz razzmatazz merged commit 4d2ff7f into razzmatazz:master Aug 19, 2023
2 checks passed
@tcx4c70 tcx4c70 deleted the fix/HostWorkspaceServices branch August 24, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error In Emacs 28.1
2 participants