Deploy To Azure Using CLI #150
Conversation
| - name: Login via Azure CLI | ||
| uses: azure/login@8c334a195cbb38e46038007b304988d888bf676a # v2 | ||
| - name: Login Via Azure CLI | ||
| uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1 |
There was a problem hiding this comment.
Why are you reverting to version 1?
There was a problem hiding this comment.
Thanks Violeta for noticing this.
Can we ignore this for the moment and expect Renovate to make subsequent PRs in order to fix all versions pinning ?
There was a problem hiding this comment.
I would like to not ignore and not put noise like this in the PR
There was a problem hiding this comment.
ok, then I'll fix this soon.
There was a problem hiding this comment.
applied feedback, see e0efd7d
There was a problem hiding this comment.
there are other dependencies that are not pinned, let me know if you want to fix them too.
There was a problem hiding this comment.
thanks, now it is obvious that this fallback to version 1 is not intentional!
There was a problem hiding this comment.
there are other dependencies that are not pinned, let me know if you want to fix them too.
not is was just this one, when someone is reviewing the PR it is good to have only relevant changes in the PR and no noise.
|
@violetagg , thanks for your review! |
This is a second attempt to deploy the site to Azure (the previous PR #147 was not working correctly).
This time this PR is doing a blue-green deployment (with zero down time) using the az cli directly, and is based on this example.