Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy To Azure Using CLI #150

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Deploy To Azure Using CLI #150

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05e960a
Deploy To Azure Using CLI
pderop Mar 5, 2024
469b537
Do not use deprecated az spring-cloud command
pderop Mar 5, 2024
e0efd7d
Applied feedback: use azure/login with SHA v2
pderop Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 52 additions & 32 deletions .github/workflows/deploy-to-azure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,21 @@ on:

permissions: read-all

env:
GROUP_NAME: ${{ secrets.AZURE_GROUP_NAME }}
SERVICE_NAME: ${{ secrets.AZURE_SERVICE_NAME }}
APP_NAME: ${{ secrets.AZURE_APP_NAME }}
JAR_PATH: ${{ github.workspace }}/build/libs/projectreactor-home.jar
DEFAULT_DEPLOYMENT: blue
NEW_DEPLOYMENT: green

jobs:
build:
deploy:
runs-on: ubuntu-latest
env:
SERVICE_NAME: ${{ secrets.AZURE_SERVICE_NAME }}
APP_NAME: ${{ secrets.AZURE_APP_NAME }}
JAR_PATH: ${{ github.workspace }}/build/libs/projectreactor-home.jar
outputs:
NEWDEPLOYMENT: ${{ steps.deploy.outputs.NEWDEPLOYMENT }}
ACTIVEDEPLOYMENT: ${{ steps.deploy.outputs.ACTIVEDEPLOYMENT }}

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-java@9704b39bf258b59bc04b50fa2dd55e9ed76b47a8 # v4
Expand All @@ -25,35 +33,47 @@ jobs:
uses: gradle/gradle-build-action@29c0906b64b8fc82467890bfb7a0a7ef34bda89e # v3
with:
arguments: build -x spotlessCheck
- name: Login via Azure CLI
uses: azure/login@8c334a195cbb38e46038007b304988d888bf676a # v2
- name: Login Via Azure CLI
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you reverting to version 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Violeta for noticing this.
Can we ignore this for the moment and expect Renovate to make subsequent PRs in order to fix all versions pinning ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to not ignore and not put noise like this in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then I'll fix this soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied feedback, see e0efd7d

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are other dependencies that are not pinned, let me know if you want to fix them too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, now it is obvious that this fallback to version 1 is not intentional!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are other dependencies that are not pinned, let me know if you want to fix them too.

not is was just this one, when someone is reviewing the PR it is good to have only relevant changes in the PR and no noise.

with:
creds: ${{ secrets.AZURE_CREDENTIALS_SPRING_IO }}
- name: Create Staging Deploy
uses: Azure/spring-apps-deploy@b70af4b78730e5bdba98ebe95c9f50376735c623 # v1
- name: Deploy To Staging
uses: azure/CLI@v1
id: deploy
with:
azure-subscription: ${{ secrets.AZURE_SUBSCRIPTION }}
action: deploy
service-name: ${{ env.SERVICE_NAME }}
app-name: ${{ env.APP_NAME }}
create-new-deployment: true
use-staging-deployment: true
package: ${{ env.JAR_PATH }}
jvm-options: -Xms1g -Xmx1g
- name: Set To Production
uses: Azure/spring-apps-deploy@b70af4b78730e5bdba98ebe95c9f50376735c623 # v1
inlineScript: |
az extension add --name spring
ACTIVEDEPLOYMENT=$(az spring app show -n ${{env.APP_NAME}} --query properties.activeDeployment.name -o tsv -s ${{env.SERVICE_NAME}} -g ${{env.GROUP_NAME}})
if [ "$ACTIVEDEPLOYMENT" = "${{env.DEFAULT_DEPLOYMENT}}" ]; then
NEWDEPLOYMENT="${{env.NEW_DEPLOYMENT}}"
else
NEWDEPLOYMENT="${{env.DEFAULT_DEPLOYMENT}}"
fi
echo 'new deployment: ' $NEWDEPLOYMENT
echo 'active deployment': $ACTIVEDEPLOYMENT
echo "::set-output name=NEWDEPLOYMENT::$NEWDEPLOYMENT"
echo "::set-output name=ACTIVEDEPLOYMENT::$ACTIVEDEPLOYMENT"
NEWDEPLOYMENTEXISTS=$(az spring app deployment list --app ${{env.APP_NAME}} --query "[?name=='$NEWDEPLOYMENT'].name" -o tsv -s ${{env.SERVICE_NAME}} -g ${{env.GROUP_NAME}})
if [ "$NEWDEPLOYMENTEXISTS" = "$NEWDEPLOYMENT" ]; then
echo $NEWDEPLOYMENT ' already exists'
else
echo 'creating deployment ' $NEWDEPLOYMENT
az spring app deployment create --app ${{env.APP_NAME}} -n $NEWDEPLOYMENT -s ${{env.SERVICE_NAME}} -g ${{env.GROUP_NAME}}
fi
echo 'workspace:' ${{ github.workspace }}
az spring app deploy -n ${{env.APP_NAME}} --artifact-path ${{env.JAR_PATH}} -d $NEWDEPLOYMENT -s ${{env.SERVICE_NAME}} -g ${{env.GROUP_NAME}}

switch-to-production:
runs-on: ubuntu-latest
needs: deploy
steps:
- uses: azure/login@v1
with:
azure-subscription: ${{ secrets.AZURE_SUBSCRIPTION }}
action: set-production
service-name: ${{ env.SERVICE_NAME }}
app-name: ${{ env.APP_NAME }}
use-staging-deployment: true
- name: Delete Staging Deployment
uses: Azure/spring-apps-deploy@b70af4b78730e5bdba98ebe95c9f50376735c623 # v1
creds: ${{ secrets.AZURE_CREDENTIALS_SPRING_IO }}
- name: Set Staging To Production
uses: azure/CLI@v1
with:
azure-subscription: ${{ secrets.AZURE_SUBSCRIPTION }}
action: delete-staging-deployment
service-name: ${{ env.SERVICE_NAME }}
app-name: ${{ env.APP_NAME }}
use-staging-deployment: true

inlineScript: |
az extension add --name spring
az spring app set-deployment -d ${{ needs.deploy.outputs.NEWDEPLOYMENT }} -n ${{env.APP_NAME}} -s ${{env.SERVICE_NAME}} -g ${{env.GROUP_NAME}}
az spring app deployment delete --app ${{env.APP_NAME}} -n ${{ needs.deploy.outputs.ACTIVEDEPLOYMENT }} -s ${{env.SERVICE_NAME}} -g ${{env.GROUP_NAME}}