Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!chore: write upgrade handler for new minimum commission rate #152

Closed
wants to merge 48 commits into from
Closed

!chore: write upgrade handler for new minimum commission rate #152

wants to merge 48 commits into from

Conversation

neitdung
Copy link
Collaborator

@neitdung neitdung commented May 6, 2024

closes #151

Description:

  • Change staking params' min commission rate to 5%
  • Update all validators commission rate

@neitdung neitdung requested a review from catShaark May 6, 2024 07:49
@catShaark
Copy link
Collaborator

can you write some tests for this

@catShaark
Copy link
Collaborator

I think this is good, tho this should target sdk47 branch

@neitdung
Copy link
Collaborator Author

Closed by realio-network

@neitdung neitdung closed this May 14, 2024
@neitdung neitdung mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catShaark catShaark catShaark left review comments

@jiujiteiro jiujiteiro Awaiting requested review from jiujiteiro jiujiteiro will be requested when the pull request is marked ready for review jiujiteiro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Upgrade handler to modify commission %
3 participants
@neitdung @catShaark @GNaD13