-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django User Management files #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acsany Overall, this looks good. I only left two small comments as of now, but let's wait until we sort out the tutorial first.
```bash | ||
(venv) $ python manage.py makemigrations | ||
(venv) $ python manage.py migrate | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a missing step:
$ cd user_auth_intro/
@@ -0,0 +1 @@ | |||
Django==5.1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably include all requirements for reproducibility:
asgiref==3.8.1
Django==5.1.3
sqlparse==0.5.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acsany LGTM!
Since this is a tutorial update, there are no
step/
folders