Add web frontend to hello-world example
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileysdev
changed the title
web frontend to hello-world example
rileysdev
changed the base branch from
main
to
benh/resemble-examples-use-rsmrc
rileysdev
force-pushed
the
riley.hello-world-web
branch
2 times, most recently
from
66c5564 to
963d7a7
Compare
rileysdev
requested review from
rjhuijsman and
benh
and removed request for
rjhuijsman
rjhuijsman
reviewed
Sep 29, 2023
| } | ||
|
|
||
| message GreetResponse { | ||
| string message = 1; // E.g. "Hello, World!". | ||
| string greeting = 1; |
There was a problem hiding this comment.
I don't really see the purpose of Greet returning the same greeting that was sent in the request? Can we just remove this field from the response?
There was a problem hiding this comment.
@sp33drac3r it seems like the comments in this file were resolved, but the changes weren't made? How come?
Current Aviator status
This PR was merged using Aviator. |
benh
force-pushed
the
benh/resemble-examples-use-rsmrc
branch
from
fb1030d to
650f685
Compare
rileysdev
force-pushed
the
riley.hello-world-web
branch
from
08aae14 to
4c8ac71
Compare
benh
approved these changes
Oct 2, 2023
rileysdev
force-pushed
the
riley.hello-world-web
branch
5 times, most recently
from
053b61f to
2cef098
Compare
rileysdev
force-pushed
the
riley.hello-world-web
branch
from
2cef098 to
a73bc25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a web frontend to hello world.
I've made a few changes to the hello-world service. We now have:
Running
rsm protocwill create some files we don't actually need, e.g. react ts bindings foroption.proto. Thoese files have been removed for source control, for now. I'm happy to add them back if anyone objects.Completes #1914
IMPORTANTLY: symlinking in the api files did not work. Copying them in did. We should restart the discussion of having
rsm protocoutput those files directly to both top level/apiand/web/src/api.I discovered #1912 as part of this PR.