Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract inline benches to a separate directory #262

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: extract inline benches to a separate directory #262

merged 1 commit into from
Jul 18, 2023

Conversation

DaniPopes
Copy link
Contributor

Motivation

Ref #261

Move inline mod bench to a separate benches/ directory. This removes the bench feature, and moves the criterion dependency to [dev-dependencies].

Includes some clippy fixes and minor refactors which are not worth making a separate PR for.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 60.52% and project coverage change: -1.59 ⚠️

Comparison is base (35167fb) 84.90% compared to head (c0c79ee) 83.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   84.90%   83.31%   -1.59%     
==========================================
  Files          50       50              
  Lines        5967     5405     -562     
==========================================
- Hits         5066     4503     -563     
- Misses        901      902       +1     
Impacted Files Coverage Δ
src/algorithms/add.rs 91.66% <ø> (ø)
src/algorithms/div/mod.rs 100.00% <ø> (ø)
src/algorithms/div/reciprocal.rs 100.00% <ø> (ø)
src/algorithms/div/small.rs 86.77% <ø> (-3.25%) ⬇️
src/algorithms/gcd/matrix.rs 93.54% <ø> (-1.12%) ⬇️
src/algorithms/gcd/mod.rs 84.27% <ø> (-0.30%) ⬇️
src/algorithms/mod.rs 100.00% <ø> (ø)
src/algorithms/ops.rs 100.00% <ø> (ø)
src/div.rs 92.30% <ø> (-1.16%) ⬇️
src/lib.rs 81.55% <ø> (-1.64%) ⬇️
... and 17 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@prestwich
Copy link
Collaborator

Cool. For clarity, the changelog is not updated because this should have no impact on the public API, correct?

@DaniPopes
Copy link
Contributor Author

Correct

@prestwich prestwich merged commit 91fa294 into recmo:main Jul 18, 2023
6 of 8 checks passed
@DaniPopes DaniPopes deleted the dani/benches branch July 18, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utils: BLOCKED) make this macro pub(crate) when supported.
2 participants