Feature/18743 fix terraform modules warnings AB#18743

[zjanura]

Multiple changes related with depricated warnings

• see the screenshots within the ticket
  -https://dev.azure.com/VolkerWesselsTelecom/Baanbrekend%20-%20Applicatie%20Integratie/_sprints/taskboard/Development/Baanbrekend%20-%20Applicatie%20Integratie/Q1%20(2024)/Sprint%2053?workitem=18303

• probably best are the necessary changes described here - at least most of them :)

• AzureAD creating an ID with applications/GUID instead just GUID with latest version v2.44.1 hashicorp/terraform-provider-azuread#1227

[tom-reinders]

I will take a closer look at this next week.
The problem with this PR is that this would be a breaking change.
We could just accept that and have to update all the lockfiles of existing projects.
An other possible solution could be changing the version constraint to not allow a later version then 2.43.0, and update the hashicorp/azuread version in the next major version we are doing.

[zjanura]

Sure, take your time and lets decide how do we approach to this.

[ArtiomMatiom]

indeed this is a breaking change (anyone who uses this module, it will stop working.

Could you keep the variable named:
soap_pass_through but make it something as follow:

api = var. api_type == null && var.soap_pass_through? "soap": var.api_type !=null? var. api_type : "http"

This way: even if someone updates the repo, it will still work with the same interface ( input variables)

[ArtiomMatiom]

based on my suggestion to not break other peoples code, I would put to null as default

[tom-reinders]

That alone is not the only breaking change.

Updating azuread_application.application.application_id to azuread_application.application.id will also break stuff.

For this to work we need to change the version of

    azuread = {
      source  = "hashicorp/azuread"
      version = "~> 2.36"
    }

application_id will only work in if we change it to version = ">= 2.36, < 2.44", because it was removed in 2.44.0, doing would in most cases not break our code, and only break for projects that have updated there .terraform.lock.hcl files to a version after 2.43.0.

For versions 2.44.0 and 2.45.0 nether will work.

id will only work in if we change it to version = "~> 2.46", because it was added in 2.46.0, doing this would be a breaking change as updating the version constraint would couse us to update all existing .terraform.lock.hcl files in all our projects.