Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to POST /reconcile #64

Closed
saumier opened this issue Mar 26, 2024 · 0 comments · Fixed by #69
Closed

Update to POST /reconcile #64

saumier opened this issue Mar 26, 2024 · 0 comments · Fixed by #69

Comments

@saumier
Copy link
Contributor

saumier commented Mar 26, 2024 •
edited
Loading

A reconciliation service MUST support HTTP POST requests at the route /reconcile

The current testbench uses GET /reconcile. The latest draft spec has removed GET and only mentions POST /reconcile.

The testbench should be updated to use POST /reconcile to be alligned with both the published spec the draft spec.
@saumier saumier mentioned this issue Apr 23, 2024
Closed
@saumier saumier linked a pull request Apr 25, 2024 that will close this issue
Use POST closes #64 #69
Merged
wetneb pushed a commit that referenced this issue Apr 29, 2024
@saumier @AbhishekPAnil
Use POST closes #64 (#69)
abf7795 
* Changed the reconciliation service request method to post,added the respective payload.closes #1

* Node engine version added to package json

* set node to v20 for engines and test matrix

* bumped to v0.2.0

---------

Co-authored-by: Abhishek P Anil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use POST closes #64 culturecreates/testbench
1 participant
@saumier