Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POST closes #64 #69

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

saumier
Copy link
Contributor

@saumier saumier commented Apr 25, 2024

A small change to the test bench to use POST instead of GET in order to better reflect the spec API v0.2

A reconciliation service MUST support HTTP POST requests on its endpoint with application/x-www-form-urlencoded bodies containing a reconciliation query batch (serialized in JSON) in a form element named queries.

The version of node was also added to the engines package.json and set to v20 which is the current active version of node https://nodejs.org/en/about/previous-releases

@saumier saumier linked an issue Apr 25, 2024 that may be closed by this pull request
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wetneb wetneb merged commit abf7795 into reconciliation-api:master Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to POST /reconcile
3 participants