Take more screenshot and add logs for BM LSO deployment #10232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Balogh <[email protected]>
DanielOsypenko
previously approved these changes
Aug 2, 2024
vavuthu
previously approved these changes
Aug 2, 2024
prsurve
previously approved these changes
Aug 2, 2024
This PR: red-hat-storage#10120 Broke original condition: if config.ENV_DATA.get("platform") != constants.BAREMETAL_PLATFORM: and changed to: if config.ENV_DATA.get("platform") in [ constants.BAREMETAL_PLATFORM, constants.HCI_BAREMETAL, ]: There should be `not in`. Which is fixed in this commit. Signed-off-by: Petr Balogh <[email protected]>
petr-balogh
dismissed stale reviews from prsurve, vavuthu, and DanielOsypenko
via
c091bfb
petr-balogh
force-pushed
the
add-more-screenshot-and-logs-for-bm-lso-deployment
branch
from
879391d to
c091bfb
Compare
vavuthu
approved these changes
Aug 2, 2024
DanielOsypenko
approved these changes
Aug 2, 2024
prsurve
approved these changes
Aug 2, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, petr-balogh, prsurve, vavuthu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Verification: |
|
/cherry-pick release-4.16 |
|
@petr-balogh: new pull request created: #10237 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10236