[release-4.16] Take more screenshot and add logs for BM LSO deployment #10237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Balogh <[email protected]>
This PR: red-hat-storage#10120 Broke original condition: if config.ENV_DATA.get("platform") != constants.BAREMETAL_PLATFORM: and changed to: if config.ENV_DATA.get("platform") in [ constants.BAREMETAL_PLATFORM, constants.HCI_BAREMETAL, ]: There should be `not in`. Which is fixed in this commit. Signed-off-by: Petr Balogh <[email protected]>
vavuthu
approved these changes
Aug 2, 2024
ebenahar
approved these changes
Aug 2, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebenahar, openshift-cherrypick-robot, vavuthu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
petr-balogh
merged commit 6205f8b
into
red-hat-storage:release-4.16
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10232
/assign petr-balogh