Fixed undefined var issues in the create.yml and delete.yml files of azure_manage_postgresql role #96
Conversation
| @@ -64,7 +64,7 @@ | |||
| value: "{{ item.value }}" | |||
| with_items: "{{ azure_manage_postgresql_postgresql_settings }}" | |||
There was a problem hiding this comment.
Won't we still have an error here if azure_manage_postgresql_postgresql_settings is not defined?
I think a better solution would be to set this in defaults/main.yml
azure_manage_postgresql_postgresql_settings: []
There was a problem hiding this comment.
I think in case of undefined var it won't even come to this line, will fail on "when". But I'll set in defaults/main.yml , thanks
There was a problem hiding this comment.
Should be able to remove the default() calls now?
There was a problem hiding this comment.
sure, sorry. I thought I already pushed it, my fault..
prabinovRedhat
force-pushed
the
fix_undefined_vars_postgresql
branch
from
77e929f to
6b9b675
Compare
| @@ -1,3 +1,4 @@ | |||
| --- | |||
| azure_manage_postgresql_operation: create | |||
| azure_manage_postgresql_postgresql_version: "11" | |||
| azure_manage_postgresql_postgresql_settings: [] | |||
There was a problem hiding this comment.
I think instead of adding empty default we should handle the "not defined" case in the role itself.
It should be done by adding the following lines:
when:
- azure_manage_postgresql_postgresql_settings is defined
- azure_manage_postgresql_postgresql_settings | length > 0
What do you think @p3ck @prabinovRedhat ?
This is something we should change in multiple places, so I'm ok with fixing it here now or leaving it with the default solution and opening new task for this
There was a problem hiding this comment.
I can add it , I'll update the PR
prabinovRedhat
force-pushed
the
fix_undefined_vars_postgresql
branch
from
f2b0d20 to
363b268
Compare
prabinovRedhat
force-pushed
the
fix_undefined_vars_postgresql
branch
from
363b268 to
0cb192f
Compare
Fixed bugs:
Fixed undefined var issue in the create.yml file of azure_manage_postgresql role (https://issues.redhat.com/browse/ACA-1839)
Fixed undefined var issue in the delete.yml file of azure_manage_postgresql role (https://issues.redhat.com/browse/ACA-1838)