fix: HTML completion / autoclose is broken when offset is inside a Qute section #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
completion-improvement
branch
4 times, most recently
from
8545800
to
83f0f92
Compare
angelozerr
force-pushed
the
completion-improvement
branch
2 times, most recently
from
b84cde8
to
418b9bc
Compare
angelozerr
changed the title
angelozerr
force-pushed
the
completion-improvement
branch
6 times, most recently
from
f92c721
to
932a89f
Compare
angelozerr
force-pushed
the
completion-improvement
branch
4 times, most recently
from
ab7e83f
to
1a9c902
Compare
angelozerr
force-pushed
the
completion-improvement
branch
2 times, most recently
from
a6d112d
to
9833c30
Compare
fbricon
reviewed
Jul 10, 2023
src/main/java/com/redhat/devtools/intellij/qute/lang/format/QuteFileIndentOptionsProvider.java
Show resolved
Hide resolved
fbricon
reviewed
Jul 10, 2023
src/main/java/com/redhat/devtools/intellij/qute/lang/format/QuteFormattingModelBuilder.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jul 10, 2023
src/main/java/com/redhat/devtools/intellij/qute/lang/psi/QuteTokenType.java
Show resolved
Hide resolved
angelozerr
force-pushed
the
completion-improvement
branch
from
9833c30
to
3622262
Compare
fbricon
reviewed
Jul 10, 2023
src/main/java/com/redhat/devtools/intellij/qute/lang/format/QuteFormattingModelBuilder.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jul 10, 2023
src/main/java/com/redhat/devtools/intellij/qute/lang/format/QuteFormattingModelBuilder.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jul 10, 2023
src/main/java/com/redhat/devtools/intellij/qute/lang/format/QuteFormattingModelBuilder.java
Outdated
Show resolved
Hide resolved
fbricon
requested changes
Jul 10, 2023
src/main/java/com/redhat/devtools/intellij/qute/lang/psi/QuteElement.java
Outdated
Show resolved
Hide resolved
section (redhat-developer#787) Fixes redhat-developer#787 Signed-off-by: azerr <[email protected]>
angelozerr
force-pushed
the
completion-improvement
branch
from
3622262
to
576d2a1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
fbricon
approved these changes
Jul 10, 2023
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: HTML completion / autoclose is broken when offset is inside a Qute
section (#787)
Fixes #787
Signed-off-by: azerr [email protected]
Here a demo:
Here a screenshot with some syntax coloration:
It is possible to customize Qute colors: