Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devfile Registry editor is to allow devfile version selection and use… #4467

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Devfile Registry editor is to allow devfile version selection and use… #4467

merged 1 commit into from
Oct 7, 2024

Conversation

vrubezhny
Copy link
Contributor

… when creating a component #4189

Fixes: #4189
Issue: #3850

@vrubezhny vrubezhny marked this pull request as draft September 13, 2024 12:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.93798% with 124 lines in your changes missing coverage. Please review.

Project coverage is 43.51%. Comparing base (da60441) to head (670fabd).
Report is 572 commits behind head on main.

Files with missing lines Patch % Lines
src/webview/devfile-registry/registryViewLoader.ts 21.73% 36 Missing ⚠️
.../webview/create-component/createComponentLoader.ts 38.18% 34 Missing ⚠️
src/registriesView.ts 23.25% 33 Missing ⚠️
src/webview/common-ext/createComponentHelpers.ts 54.16% 11 Missing ⚠️
src/devfile-registry/devfileRegistryWrapper.ts 87.65% 10 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4467       +/-   ##
===========================================
+ Coverage   32.37%   43.51%   +11.13%     
===========================================
  Files          85       98       +13     
  Lines        6505     8002     +1497     
  Branches     1349     1702      +353     
===========================================
+ Hits         2106     3482     +1376     
- Misses       4399     4520      +121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny force-pushed the fix-devfile-registry-editor-version-select branch 8 times, most recently from 29ea326 to 2e80f02 Compare September 20, 2024 16:06
@vrubezhny vrubezhny force-pushed the fix-devfile-registry-editor-version-select branch 3 times, most recently from ce00ceb to 5e119c3 Compare September 23, 2024 11:43
@vrubezhny vrubezhny marked this pull request as ready for review September 23, 2024 12:03
@vrubezhny vrubezhny force-pushed the fix-devfile-registry-editor-version-select branch from 5e119c3 to e5a6879 Compare September 24, 2024 00:29
@vrubezhny vrubezhny mentioned this pull request Sep 24, 2024
Merged
@vrubezhny vrubezhny force-pushed the fix-devfile-registry-editor-version-select branch from e5a6879 to a880bac Compare September 24, 2024 20:16
@datho7561
Copy link
Contributor

adding new Devfile registries doesn't seem to work. I tried to add http://registry.stage.devfile.io , and nothing happened: no warnings and it didn't appear in the "Devfile Registries" section of the sidebar

@vrubezhny
Copy link
Contributor Author

adding new Devfile registries doesn't seem to work. I tried to add http://registry.stage.devfile.io , and nothing happened: no warnings and it didn't appear in the "Devfile Registries" section of the sidebar

Try refreshing the Devfile Registry View tree - that is a known issue I fixed in #4473.

@datho7561
Copy link
Contributor

Refreshing didn't work for me. That other PR says that it depends on this one in order to work - is that still the case? Is it possible to move the fix to this PR?

@vrubezhny
Copy link
Contributor Author

Refreshing didn't work for me. That other PR says that it depends on this one in order to work - is that still the case? Is it possible to move the fix to this PR?

I could try implementing the fix in this PR... the problem is that it'll need to make even more changes in depending #4473 due to conflicts (as it changes the same code)

@datho7561
Copy link
Contributor

Should I focus on reviewing the other PR then?

@vrubezhny
Copy link
Contributor Author

Should I focus on reviewing the other PR then?

Adding/removing devfile registries are not the part of this PR....

With this one you can focus on the following goals:

  1. to provide a possibility to change the version of a devfile when creating a component (from Devfile Registry editor, a template, a git repository or a local codebase) and making sure that everything still works and the selected devfile version is really applied for a component created.
  2. Overall performance improvement (we don't need to read whole the devfile registries contents together with the default devfile versions attached into the memory at start and keep it in while working with the extension).
  3. getting rid of odo registry and odo registry --detail usages

The #4473 - is exactly about devfile registry tree, adding/changing/removing registries, refreshing the tree and the cache maintenance and getting rid of odo preference view, odo preference add registry and odo preference remove registry

datho7561
datho7561 requested changes Sep 30, 2024
View reviewed changes
src/openshift/component.ts Outdated Show resolved Hide resolved
src/registriesView.ts Show resolved Hide resolved
src/webview/create-component/pages/fromExistingGitRepo.tsx Outdated Show resolved Hide resolved
@vrubezhny vrubezhny force-pushed the fix-devfile-registry-editor-version-select branch 2 times, most recently from 53207f5 to 0ed199c Compare October 7, 2024 15:06
@vrubezhny vrubezhny force-pushed the fix-devfile-registry-editor-version-select branch from 0ed199c to ab6662e Compare October 7, 2024 15:28
@vrubezhny vrubezhny force-pushed the fix-devfile-registry-editor-version-select branch from ab6662e to 670fabd Compare October 7, 2024 18:17
datho7561
datho7561 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, Victor! Thanks for your patience during the review.

@datho7561 datho7561 merged commit 763c43e into redhat-developer:main Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

@msivasubramaniaan msivasubramaniaan Awaiting requested review from msivasubramaniaan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Devfile Registry editor is to allow devfile version selection and use when creating a component
3 participants
@vrubezhny @codecov-commenter @datho7561